Repository navigation
Fix remaining CI diagnostic guidance gaps - #71688
Conversation
Document dry-run severity handling and runtime diagnostic remedies within the playbook consumption budget. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
✅ PR Code Quality Reviewer completed the code quality review.
|
|
✅ Ponytail Reviewer completed successfully! Ponytail ReviewerOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅
|
|
✅ Test Quality Sentinel completed test quality analysis. Test Quality SentinelOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
There was a problem hiding this comment.
🟢 Approval recommended
The changes affect documentation only, and the remaining suggestions are minor clarifications rather than approval blockers.
3 open issues
What changed in this PR
Expands gh-aw’s CI troubleshooting guidance to cover missing diagnostics while preserving the playbook’s enforced size limits.
Changes:
- Adds evidence checks and remedies for 10 runtime diagnostic codes.
- Documents low-severity and informational handling during dry-run compilation.
- Condenses existing guidance without changing runtime behavior.
| File | Description |
|---|---|
.github/aw/debug-playbook.md |
Adds diagnostic entries and condenses existing troubleshooting guidance. |
.github/aw/cli-commands.md |
Adds a dry-run compilation severity summary. |
Review effort: Max
| Low-severity/informational notices are not blanket failures; validation errors, | ||
| unclassified compiler warnings, model-inventory failures, built-in AST lint findings, | ||
| and scanner execution/parsing failures remain fatal to the dry-run gate. |
| | `E002`, `MAX_COUNT_REACHED` | Operation cap; accepted records. | Reduce count; never replay applied mutations. | | ||
| | `E003` | Named count/size limit. | Split/reduce authorized payload. | | ||
| | `ERR_PERMISSION`, `E004`, `APPROVE_WORKFLOW_RUN_PERMISSION_DENIED`, `DISCUSSIONS_TOKEN_SCOPE_MISMATCH` | Target, allowlist/effect scope, job permissions, token type. | Fix authorized target/permissions; never expose tokens/evade guards. | | ||
| | `ERR_PERMISSION`, `E004`, `APPROVE_WORKFLOW_RUN_PERMISSION_DENIED`, `DISCUSSIONS_TOKEN_SCOPE_MISMATCH` | Target/scope, permissions, token type. | Fix authorized permissions; never expose tokens/evade guards. | |
| | `ERR_WORK_QUEUE_CLAIM_SCOPE`, `assignment_invalid`, `assignment_immutable`, `claim_invalid`, `claim_missing`, `claim_conflict`, `claim_ineffective` | Immutable array of 1-16 Claims; owner, epoch, deadline. | Fix producer/reconcile; preserve effective Claim identities/scopes. | | ||
| | `claim_scope_invalid`, `claim_scope_required`, `claim_effects_unauthorized`, `claim_control_delivery_invalid` | Claim handle/factory, scope, control delivery. | Retain original write scope and validated control intent. | |
|
🎉 This pull request is included in a new release. Release: |
make test-guidancestill failed at 7e8da8d after the earlier work-queue guidance fix: the compile reference lacked its severity policy and the debug playbook omitted 10 runtime diagnostic codes.Adds the missing low-severity/informational guidance and code-specific evidence/remedy entries. Condenses existing prose to preserve the playbook's enforced word and byte budgets without weakening tests or changing runtime behavior.
Validation: all 56 guidance tests pass, and
make agent-report-progresspasses.