Skip to content

Fix Update Astro dependency downloads and upgrade command - #71619

Merged
pelikhan merged 2 commits into
mainfrom
copilot/update-astro-finish-output
Oct 24, 2026
Merged

pelikhan merged 2 commits into
mainfrom
copilot/update-astro-finish-output

Conversation

Copilot AI commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Update Astro stopped without a terminal safe output after npm hit a certificate error downloading a mirror-pinned tarball. The workflow also instructed the agent to use an unsupported npm-check-updates flag.

  • Registry URLs: Replace 32 mirror URLs in the docs lockfile with canonical HTTPS npm URLs, preserving dependency versions and integrity hashes.
  • Updater command: Change --update to --upgrade and regenerate the compiled workflow lock.
  • Regression coverage: Guard canonical tarball URLs, integrity hashes, and the supported upgrade flag.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix Astro update to provide terminal safe output Fix Update Astro dependency downloads and upgrade command Oct 24, 2026
Copilot AI requested a review from pelikhan October 24, 2026 11:11
@pelikhan
pelikhan marked this pull request as ready for review October 24, 2026 11:12
Copilot AI max review requested due to automatic review settings October 24, 2026 11:12
@pelikhan
pelikhan merged commit 1ea0d3e into main Oct 24, 2026
3 checks passed
@pelikhan
pelikhan deleted the copilot/update-astro-finish-output branch October 24, 2026 11:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new regression suite is not connected to automated test runners, leaving the intended safeguards inactive.

1 open issue
1 file not reviewed
  • docs/package-lock.json: Generated file
What changed in this PR

Addresses dependency-download and command failures encountered by gh-aw’s automated Astro documentation updater in #71537.

Changes:

  • Replace 32 mirror tarball URLs with canonical npm URLs, preserving versions and integrity hashes.
  • Switch to npm-check-updates --upgrade and regenerate the workflow lock.
  • Add regression checks for tarball URLs, integrity presence, and the upgrade flag.
File Description
scripts/​update-astro.test.cjs Adds lockfile and updater-command regression checks.
docs/​package-lock.json Replaces mirror URLs with canonical npm tarball URLs.
.github/​workflows/​update-astro.md Uses the supported --upgrade flag.
.github/​workflows/​update-astro.lock.yml Refreshes compiled workflow and admission hashes.

Review effort: Max


const root = path.join(__dirname, "..");

test("Update Astro uses the supported npm-check-updates upgrade flag", () => {
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.93.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[aw] Update Astro: finished without a terminal safe output

3 participants