[Copilot]

mapdeletecheck misses redundant membership checks when map or key expressions have different parenthesis wrapping between the lookup and delete call.

• Expression matching: Unwrap each operand independently before comparison; remove the symmetric-only ParenExpr case.
• Regression coverage: Add five diagnostic/autofix cases covering both key directions, map operands, and unequal nesting depths. Autofixes continue using the original lookup expressions.

// Previously missed:
if _, ok := m[(k)]; ok {
	delete(m, k)
}

// Suggested replacement:
delete(m, (k))

• Fixes mapdeletecheck: sameExpr requires symmetric ParenExpr wrapping, asymmetric-paren map/key matches escape detection #71550

[github-actions]

✅ Test Quality Sentinel completed test quality analysis.

Test Quality Sentinel

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Test Quality Sentinel · sonnet50 · ~17 AIC · ⌖ ~16 AIC · ◇ ~5 AIC · ⊞ 12.7K · ◷

🧪 Test quality analysis by Test Quality Sentinel

[github-actions]

✅ Ponytail Reviewer completed successfully!

Ponytail Reviewer

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Ponytail Reviewer · gpt56 · ~6 AIC · ⌖ ~6 AIC · ⊞ 14.8K · ◷

Generated by Ponytail Reviewer for #71618

[github-actions]

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

[github-actions]

✅ PR Code Quality Reviewer completed the code quality review.

🔎 Code quality review by PR Code Quality Reviewer

[github-actions]

✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft.

Design Decision Gate 🏗️

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Design Decision Gate 🏗️ · opus55 · ~11 AIC · ⌖ ~33 AIC · ◇ ~14 AIC · ⊞ 1.9K · ◷

🏗️ ADR gate enforced by Design Decision Gate 🏗️

[github-actions]

Review summary

No actionable issues found in the changed lines. Independently checked the parenthesis unwrapping against the existing sameExpr cases and the new asymmetric-parenthesis fixtures; the change preserves identifier/type-identity comparisons while extending matching as intended. Static review only; no tests were run.

🔎 Code quality review by PR Code Quality Reviewer · copilot · gpt50 · ~2 AIC · ⌖ ~1 AIC · ⊞ 1.6K
_{Comment /review to run again}

[Copilot]

🟢 Approval recommended

The localized matching fix preserves autofix behavior, with only non-blocking test-fixture improvements remaining.

1 open issue

• Add regression coverage for unequal lookup and delete nesting · New

What changed in this PR

Fixes mapdeletecheck false negatives when lookup and delete operands have different parenthesis wrapping, while preserving lookup-based autofixes.

Changes:

• Unwrap both comparison operands independently and remove the symmetric-only parenthesis case.
• Add parenthesized map/key diagnostic fixtures and expected autofix output.

File	Description
pkg/​linters/​mapdeletecheck/​testdata/​src/​mapdeletecheck/​mapdeletecheck.go.golden	Expected autofixes for the new fixtures.
pkg/​linters/​mapdeletecheck/​testdata/​src/​mapdeletecheck/​mapdeletecheck.go	Diagnostic cases for parenthesized map and key operands.
pkg/​linters/​mapdeletecheck/​mapdeletecheck.go	Independent parenthesis unwrapping during expression comparison.

_{Review effort: Max}

[github-actions]

🎉 This pull request is included in a new release.

Release: v0.93.4