Skip to content

[instructions] Sync instruction files with release v0.93.2 - #71598

Merged
pelikhan merged 4 commits into
mainfrom
instructions-sync-v0.93.2-78138123fc2e80c1
Oct 24, 2026
Merged

pelikhan merged 4 commits into
mainfrom
instructions-sync-v0.93.2-78138123fc2e80c1

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Audit summary

Release baseline: v0.93.2 (published 2026-10-23T05:57:09Z). Local checkout is shallow (single commit), so release/change history was gathered via GitHub MCP list_commits/get_commit instead of local git diff/git log against the tag.

Documentation commits reviewed since release (5, excluding a blog post):

  • 1233a55c — trimmed debug-workflow-evidence.md under 400 lines (already compliant, no action)
  • ddaf87da — FAQ clarification that workflow_call reusable workflows must live directly in .github/workflows/; this concerns GitHub Actions' native reuse mechanism, distinct from gh-aw's import-based shared components in create-shared-agentic-workflow.md — no inconsistency found
  • 88cc9828 — feat: lint workflows during compilation by default (feat: lint workflows during compilation by default #71349, major/breaking) — addressed below
  • 9084a8c7 — self-hosted runner proxy inheritance + Grype scan-completeness docs; infra/admin-facing content not currently mirrored into .github/aw/, and --grype/--runner-guard were already undocumented there before this release (pre-existing gap, not a regression from this release — left out of scope)
  • 0489b24e — daily work-queue smoke workflows + Bash 3 validation; only touched generated .lock.yml files, no .md instruction content

Files changed

  • .github/aw/cli-commands.md (396 → 399 lines): added gh aw compile --skip-lint to the command list and a note that compilation now runs built-in Actions/AW AST lint by default (including --no-emit/validate) and fails on findings, with --skip-lint (MCP skip_lint: true) rejected together with --dry-run. Also trimmed one sentence duplicated by debug-compilation.md's own severity coverage to stay under the 400-line limit.
  • .github/aw/debug-compilation.md (253 → 130... actually 124 → 130 lines): added built-in AST lint findings to the existing "remains fatal" list and a short paragraph distinguishing default AST lint (new) from the opt-in zizmor/actionlint/poutine scanners, noting --skip-lint is rejected with --dry-run.

Verified the --skip-lint flag, its --dry-run incompatibility, and the MCP skip_lint parameter directly against source (pkg/cli/compile_config.go, pkg/cli/compile_compiler_setup_test.go, pkg/cli/mcp_tools_readonly.go) rather than relying solely on the changeset description.

Size audit

wc -l .github/aw/*.md — all 79 files are under the 400-line target both before and after edits (max is now cli-commands.md at 399).

Duplication audit

Removed one sentence from cli-commands.md ("Low-severity/informational notices are not blanket failures") that duplicated debug-compilation.md's own detailed severity coverage, consistent with the index-file-should-reference-not-restate principle.

Accuracy audit

Confirmed via source that --skip-lint, skip_lint, and their --dry-run incompatibility exist as described in the release changeset (.changeset/compile-default-ast-lint.md). No other schema/safe-outputs drift found in pkg/workflow/compiler_types.go, pkg/workflow/safe_outputs_config.go, or the main workflow JSON schema relevant to these changes.

Steering

Checked issue #71594 for steer-tagged comments; none present.

🤖 Generated with [Claude Code]((claude.com/redacted)

Generated by 🧹 Instructions Janitor · claude · sonnet50 · ~166 AIC · ⌖ ~19 AIC · ⊞ 6.7K · ◷

  • expires on Oct 26, 2026, 12:45 AM UTC-08:00

gh aw compile now runs built-in Actions/AW AST lint by default and
fails on findings (release v0.93.2, PR #71349); cli-commands.md and
debug-compilation.md had no mention of this or the --skip-lint escape
hatch. Also trims a sentence in cli-commands.md duplicated by
debug-compilation.md's existing severity coverage, to stay under the
400-line instruction-file limit.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot rename --skip-lint to --no-lint for consistency

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI commented Oct 24, 2026

Copy link
Copy Markdown
Contributor

@copilot rename --skip-lint to --no-lint for consistency

Renamed the compile CLI flag to --no-lint across implementation, tests, and docs; the MCP skip_lint field remains unchanged. Commit: b0a6320.

Copilot AI requested a review from pelikhan October 24, 2026 10:32
@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot address the following outstanding work in one pass:

  1. Update this branch with the latest main using make merge-main, resolving any conflicts and preserving the intended changes.
  2. Fix failing check impacted-go-tests (FAILURE): https://github.com/github/gh-aw/actions/runs/40086173460/job/120853940420.

Push the necessary fixes, reply to each listed review thread and resolve it when addressed. Ignore feedback already answered or resolved. Use the pr-finisher skill and stop when only human review or CI remains; do not trigger CI.

Sous-chef head: b0a6320
Sous-chef work: 42e5d572d9d75b7168fe7d0aeda0717cc07e65ed240f6d299e6fec661214f1ac
Sous-chef state: d90421304311d12a99edfe99bfee2fdfa0cbe1cd496fb5d1078fd584b68704fb

Generated by 👨‍🍳 PR Sous Chef · pi · haiku45 · ~4 AIC · ⌖ ~8 AIC · ⊞ 1.1K · ◷
Comment /souschef to run again

Copilot AI and others added 2 commits October 24, 2026 11:17
…93.2-78138123fc2e80c1

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI commented Oct 24, 2026

Copy link
Copy Markdown
Contributor

@copilot address the following outstanding work in one pass:

  1. Update this branch with the latest main using make merge-main, resolving any conflicts and preserving the intended changes....

Merged latest main (852f528) and fixed the impacted test failure; the targeted test and full pkg/cli suite pass. The final impacted-test gate passed its tests but stopped on unrelated existing custom-linter findings. Commit: 3042ecb. There are no open review threads to resolve.

Copilot AI requested a review from gh-aw-bot October 24, 2026 11:41
@pelikhan
pelikhan merged commit 6420430 into main Oct 24, 2026
2 checks passed
@pelikhan
pelikhan deleted the instructions-sync-v0.93.2-78138123fc2e80c1 branch October 24, 2026 14:52
@github-actions

Copy link
Copy Markdown
Contributor Author

🎉 This pull request is included in a new release.

Release: v0.93.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automation documentation Improvements or additions to documentation instructions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants