Repository navigation
Fix CI instruction drift and registry-dependent negative tests - #71241
Conversation
Refresh offline guide discovery and validate split debugging guidance at its owning pages. Move missing-image assertions to deterministic Docker tests while retaining positive live integration coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
✅ Test Quality Sentinel completed test quality analysis. Test Quality SentinelOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft. Design Decision Gate 🏗️Outcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ Ponytail Reviewer completed successfully! Ponytail ReviewerOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅
|
|
✅ PR Code Quality Reviewer completed the code quality review.
|
There was a problem hiding this comment.
🟢 Approval recommended
The focused test and fallback-list changes preserve production validation behavior and have no unresolved blocking findings.
No open issues 🎉
What changed in this PR
This PR improves gh-aw CI reliability by aligning instruction checks with the specialized debugging guides and making missing-image tests independent of registry availability. Production Docker validation behavior is unchanged.
Changes:
- Update instruction assertions to check the owning guides and verify links from the main debugging guide.
- Add the split debugging guides to the offline fallback list.
- Move missing-image assertions to fake-Docker coverage, verify no retry occurs, and retain positive live Docker checks.
| File | Description |
|---|---|
pkg/workflow/validation_test.go |
Remove registry-dependent negative cases while retaining positive integration coverage. |
pkg/workflow/docker_validation_readonly_test.go |
Add deterministic missing-image error and no-retry assertions. |
pkg/cli/data/agentic_workflows_fallback_aw_files.json |
Include the specialized debugging guides in the offline list. |
pkg/cli/copilot_agents_test.go |
Align debugging assertions and guide-link checks with the split documentation. |
Review effort: Max
|
🎉 This pull request is included in a new release. Release: |
Why
Main's CGO checks fail because debugging guidance was split into specialized pages without updating the instruction assertions or embedded offline guide list. CI integration checks also fail when registry throttling replaces the expected missing-image error.
Changes
No production Docker validation behavior changes.
Validation
no space left on device). Shared Docker resources were left untouched.