Skip to content

Fix CI instruction drift and registry-dependent negative tests - #71241

Merged
pelikhan merged 1 commit into
mainfrom
pelikhan-shiny-broccoli
Oct 22, 2026
Merged

pelikhan merged 1 commit into
mainfrom
pelikhan-shiny-broccoli

Conversation

@pelikhan

Copy link
Copy Markdown
Collaborator

Why

Main's CGO checks fail because debugging guidance was split into specialized pages without updating the instruction assertions or embedded offline guide list. CI integration checks also fail when registry throttling replaces the expected missing-image error.

Changes

  • Check debugging requirements in their owning guides and verify the strategy links to them; refresh the offline guide list.
  • Move missing-image assertions to deterministic fake-Docker coverage, including checking that a missing manifest is not retried. Retain positive live Docker integration coverage.

No production Docker validation behavior changes.

Validation

  • Build, formatting, targeted regression tests with race detection, custom linters, impacted unit tests, and workflow drift checks passed.
  • Go lint passed on retry with a longer timeout after the initial gate timed out.
  • Live positive Docker integration checks could not pass locally because Docker storage is full (no space left on device). Shared Docker resources were left untouched.

Refresh offline guide discovery and validate split debugging guidance at its owning pages. Move missing-image assertions to deterministic Docker tests while retaining positive live integration coverage.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@pelikhan
pelikhan marked this pull request as ready for review October 22, 2026 23:24
Copilot AI max review requested due to automatic review settings October 22, 2026 23:24
@pelikhan
pelikhan merged commit 7a41104 into main Oct 22, 2026
37 of 47 checks passed
@pelikhan
pelikhan deleted the pelikhan-shiny-broccoli branch October 22, 2026 23:24
@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

✅ Test Quality Sentinel completed test quality analysis.

Test Quality Sentinel

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Test Quality Sentinel · haiku45 · ~6 AIC · ⌖ ~7 AIC · ◇ ~5 AIC · ⊞ 9.2K · ◷

🧪 Test quality analysis by Test Quality Sentinel

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft.

Design Decision Gate 🏗️

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Design Decision Gate 🏗️ · opus55 · ~12 AIC · ⌖ ~37 AIC · ◇ ~15 AIC · ⊞ 1.9K · ◷

🏗️ ADR gate enforced by Design Decision Gate 🏗️

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

✅ Ponytail Reviewer completed successfully!

Ponytail Reviewer

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Ponytail Reviewer · gpt56 · ~7 AIC · ⌖ ~6 AIC · ⊞ 14.8K · ◷

Generated by Ponytail Reviewer for #71241

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

✅ PR Code Quality Reviewer completed the code quality review.

🔎 Code quality review by PR Code Quality Reviewer

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused test and fallback-list changes preserve production validation behavior and have no unresolved blocking findings.

No open issues 🎉

What changed in this PR

This PR improves gh-aw CI reliability by aligning instruction checks with the specialized debugging guides and making missing-image tests independent of registry availability. Production Docker validation behavior is unchanged.

Changes:

  • Update instruction assertions to check the owning guides and verify links from the main debugging guide.
  • Add the split debugging guides to the offline fallback list.
  • Move missing-image assertions to fake-Docker coverage, verify no retry occurs, and retain positive live Docker checks.
File Description
pkg/​workflow/​validation_test.go Remove registry-dependent negative cases while retaining positive integration coverage.
pkg/​workflow/​docker_validation_readonly_test.go Add deterministic missing-image error and no-retry assertions.
pkg/​cli/​data/​agentic_workflows_fallback_aw_files.json Include the specialized debugging guides in the offline list.
pkg/​cli/​copilot_agents_test.go Align debugging assertions and guide-link checks with the split documentation.

Review effort: Max

@github-actions

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.93.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants