Repository navigation
docs: cover empty-output failure codes in debug playbook - #70676
Merged
Merged
Conversation
Apply the diagnostic evidence and remedies proposed in #70661 while retaining the playbook size budget. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
|
🔎 PR Code Quality Reviewer is reviewing code quality for this pull request... |
Contributor
|
🔬 Test Quality Sentinel is analyzing test quality on this pull request... |
Contributor
|
✂️ Ponytail Reviewer has started processing this pull request |
Contributor
|
🧠 Matt Pocock Skills Reviewer is reviewing this pull request using Matt Pocock's engineering skills... |
This was referenced Oct 21, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The documentation-only change preserves safety safeguards and has only minor clarity suggestions, with no blocking issues.
2 open issues
What changed in this PR
Updates the debugging playbook to cover missing empty-output failure codes without changing workflow or runtime behavior.
Changes:
- Adds evidence and remedies for
driver_crashandsecret_redaction_failure. - Distinguishes crashes from outages and preserves redaction safeguards.
- Tightens prose to retain the 2,800-word budget.
| File | Description |
|---|---|
.github/aw/debug-playbook.md |
Completes diagnostic coverage and condenses surrounding guidance. |
Review effort: Max
| Trace causes, not cascades; compare one relevant success if needed. | ||
| Timeout: incomplete JSON report possible. Fetch only missing evidence. | ||
| Read only the linked `key_findings[].playbook_url` or exact-code row. | ||
| Trace causes, not cascades; compare one success. |
| | --- | --- | --- | | ||
| | `agent_startup_failure` | First setup/engine error. | Fix startup; missing output need not be agent choice. | | ||
| | `engine_driver_failure` | Driver exit; final native event. | Fix driver before output instructions. | | ||
| | `engine_driver_failure`, `driver_crash` | Driver exit/signal; final native error. | Fix driver first; nonzero exit alone doesn't establish outage. | |
This was referenced Oct 21, 2026
This was referenced Oct 21, 2026
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The diagnostic guidance check fails because the debug playbook lacks evidence and remedy coverage for
driver_crashandsecret_redaction_failure.Apply the patch proposed in #70661: distinguish driver crashes from engine outages and require repairing redaction before publication without exposing raw logs or disabling masking. Tighten surrounding prose to preserve the existing 2,800-word budget. No workflow or runtime behavior changes.
Validation
make test-guidance: all 15 tests pass, including diagnostic coverage and word/byte budgets.PATH="/opt/homebrew/bin:$PATH" make agent-report-progress: passed using Bash 5 because macOS's default Bash lacksmapfile.git diff --check: passed.Closes #70661