Repository navigation
Fix removed GDK_DEBUG gl-no-fractional - #7233
Conversation
|
First of all, why is this necessary? gl-no-fractional has not done anything for quite a while but all it does is adding a log message at startup. Unless GTK 4.17.5+ can't recover from having an invalid debug flag (which isn't true) this shouldn't need to be here. There are still some users that are using GTK versions that are quite a bit older (Debian 12 ships GTK 4.8, for example) and might still benefit from this. |
I just added upper bound check, nothing had changed. It's still error and it better be fixed I thought. Also minimum version for that flag is GTK v4.14 (v4.13.6), so I think it's fine. |
|
If the only intention here is to suppress the unknown debug flag message then this PR makes a lot more sense - thanks. Still, it was definitely removed at a point a lot earlier than 4.17.5; if we were to really care about this we should have due diligence and set the upper bound to whichever version first removed it. |
|
Thanks. I double checked, its 4.17.5. |
| gdk_debug.@"gl-no-fractional" = true; | ||
| gdk_debug.@"vulkan-disable" = true; | ||
|
|
||
| if (gtk_version.runtimeUntil(4, 17, 5)) { |
There was a problem hiding this comment.
I know it didn't exist before, but we should take this opportunity to add a comment about why we set this at all. The history starts here: #4255
I'm not sure how to word the explanation because I myself don't fully grasp the nature of fractional scaling with GTK yet. I just know we don't handle it well at the moment and it causes blurriness. I think the blurriness returned after they removed this and we need to still address this. I'm not sure.
There was a problem hiding this comment.
There is upstream issue about it. (GNOME/gtk#6514), so.. best solution was to rely on upstream fix but I thought quick dirty fix was better.
NGL has little issue on fractional scaling which can cause blurry fonts, and gl-no-fractional just reverts it and do integer scaling. it makes fonts crisp, but its legacy solution.
mitchellh
left a comment
mitchellh
left a comment
There was a problem hiding this comment.
One comment. I won't approve/deny here, I'm fine merging without my comment being addressed, but did want to note it. I think removing the noisy log message is good because it does lead people to feel they should report a bug.
gl-no-fractionalis removed from GTK v4.17.5