⭐ Must Read: ghostty org/ghostty/pull/

jcollie · 2025-02-25T18:19:00Z

Partial implementation of #5256

This implements the core changes necessary to open urls using an apprt action rather than doing it directly from the core.

Implements the open_url action in the GTK apprt.

Note that this should not be merged until a macOS-savvy developer can add an implementation of the open_url action for the macOS apprt.

tristan957 · 2025-02-25T18:31:04Z

Did you see https://flatpak.github.io/xdg-desktop-portal/docs/doc-org.freedesktop.portal.OpenURI.html? Seems like we should use that and then fallback to xdg-open.

mitchellh

Thanks for starting this, I can take a look for libghostty.

jcollie · 2025-02-25T19:15:38Z

Did you see https://flatpak.github.io/xdg-desktop-portal/docs/doc-org.freedesktop.portal.OpenURI.html? Seems like we should use that and then fallback to xdg-open.

That looks interesting but I'd rather take that on in a follow-up PR after this is merged.

tristan957

Would open_uri be a better name than open_url?

tristan957 · 2025-06-24T17:39:26Z

Would open_uri be a better name than open_url?

Is this something you've considered? Maybe I'm blind.

tristan957 · 2025-06-24T17:40:09Z

Did you see https://flatpak.github.io/xdg-desktop-portal/docs/doc-org.freedesktop.portal.OpenURI.html? Seems like we should use that and then fallback to xdg-open.

TIL that xdg-open uses the portal already, so I wonder if there is any benefit to using the portal directly vs just calling xdg-open. Maybe lower overhead?

jcollie · 2025-06-24T18:14:03Z

TIL that xdg-open uses the portal already, so I wonder if there is any benefit to using the portal directly vs just calling xdg-open. Maybe lower overhead?

Yeah, you could avoid the thread spawn and fork/exec in Ghostty, but that's pretty minimal since I doubt that it's going to be called thousands of times per second. The benefit of calling xdg-open is making the logic of making the magic of that happen "not our problem".

jcollie · 2025-06-24T18:20:15Z

I've updated the PR to rebase on top of #7657 so there's no special "open on linux" function anymore. This still needs a macOS implementation of the open_url action before merging.

pluiedev · 2025-06-24T18:33:54Z

Actually, I just realized that xdg-open isn't just a wrapper around the D-Bus API — instead it's a bash script that uses a bunch of heuristics to figure out what the user's desktop environment is, and then uses the DE-specific utilities when possible (gio open on GNOME, kde-open on KDE, etc.). In fact, it seems to only use the portal when it's running inside Flatpak. I guess then it would still be worth keeping it in case the user doesn't have a working portal (which seems to be concerningly common for a lot of our users)...?

tristan957 · 2025-06-24T19:08:39Z

Actually, I just realized that xdg-open isn't just a wrapper around the D-Bus API — instead it's a bash script that uses a bunch of heuristics to figure out what the user's desktop environment is, and then uses the DE-specific utilities when possible (gio open on GNOME, kde-open on KDE, etc.). In fact, it seems to only use the portal when it's running inside Flatpak. I guess then it would still be worth keeping it in case the user doesn't have a working portal (which seems to be concerningly common for a lot of our users)...?

So then, I think my position will continue to be prioritize the portal with an xdg-open fallback (future work). Thanks for your research.

tristan957 · 2025-06-24T19:12:16Z

Hm, I guess I have a question. Why does libghostty do the physical opening. Why isn't it left to the apprt? Meaning the macOS apprt would run open for instance.

jcollie · 2025-06-24T21:04:36Z

Hm, I guess I have a question. Why does libghostty do the physical opening. Why isn't it left to the apprt? Meaning the macOS apprt would run open for instance.

The open function is in libghostty because there's a lot of functionality shared across all the apprts (it's also used by the "open config". If an apprt wanted to do something other than launch a CLI command (some sort of DBus call for GTK, native Swift API call for macOS, some Win32 call for Windows) that can be handled in the open_url apprt handler (GTK: https://github.com/ghostty-org/ghostty/blob/00f824d0efb441bbfe2057e7caeadfcec2ea1d48/src/apprt/gtk/App.zig#L1722-L1730)

Partial implementation of ghostty-org#5256 This implements the core changes necessary to open urls using an apprt action rather than doing it directly from the core. Implements the open_url action in the GTK and GLFW apprts. Note that this should not be merged until a macOS-savvy developer can add an implementation of the open_url action for the macOS apprt.

mitchellh · 2025-07-06T22:06:36Z


-const log = std.log.scoped(.@"os-open");
+const apprt = @import("../apprt.zig");
+const CircBuf = @import("../datastruct/circ_buf.zig").CircBuf;


On a future note, your PRs have a pattern of containing unrelated changes such as this. I'm going to revert all the circular buffer stuff. It makes sense but conflating the purpose and goal of a PR makes review harder and makes things like reverting uglier if we ever to. I'd appreciate keeping things tightly scoped.

mitchellh · 2025-07-06T22:18:38Z

Okay, I made it so that if the apprt doesn't support this we fallback to our old implementation. This will let us merge this without worrying about macOS. I'll make a follow up issue for that. Once CI passes we're good.

jcollie requested review from a team as code owners February 25, 2025 18:19

tristan957 approved these changes Feb 25, 2025

View reviewed changes

mitchellh requested changes Feb 25, 2025

View reviewed changes

Comment thread src/os/open.zig Outdated

Comment thread src/apprt/action.zig Outdated

jcollie force-pushed the apprt-action-open-url branch from 20f4b88 to 4dde6f4 Compare February 25, 2025 19:13

jcollie mentioned this pull request Feb 25, 2025

GTK: use portals to open URLs instead of xdg-open #5991

Closed

pluiedev added the os/linux label Feb 28, 2025

jcollie force-pushed the apprt-action-open-url branch 2 times, most recently from d339ac3 to 0a69243 Compare March 10, 2025 12:05

jcollie force-pushed the apprt-action-open-url branch from 0a69243 to 70af7a1 Compare March 18, 2025 23:40

jcollie force-pushed the apprt-action-open-url branch 2 times, most recently from 7e852df to aa8e7f2 Compare April 10, 2025 21:23

jcollie force-pushed the apprt-action-open-url branch 2 times, most recently from 1568fd7 to 7fafa50 Compare May 8, 2025 19:23

jcollie commented May 8, 2025

View reviewed changes

Comment thread src/apprt/action.zig Outdated

jcollie force-pushed the apprt-action-open-url branch 4 times, most recently from daa12b3 to 7a0028a Compare May 19, 2025 13:04

jcollie force-pushed the apprt-action-open-url branch from 7a0028a to 83d5127 Compare May 29, 2025 16:40

pluiedev requested changes May 29, 2025

View reviewed changes

Comment thread src/apprt/action.zig Outdated

Comment thread src/os/open.zig Outdated

Comment thread src/os/open.zig Outdated

tristan957 reviewed May 29, 2025

View reviewed changes

00-kat reviewed May 30, 2025

View reviewed changes

Comment thread src/os/open.zig Outdated

jcollie force-pushed the apprt-action-open-url branch from 83d5127 to fe996ca Compare June 13, 2025 16:35

jcollie mentioned this pull request Jun 23, 2025

fix: always wait on open command to avoid defunct processes #7657

Merged

jcollie force-pushed the apprt-action-open-url branch from fe996ca to 3b66483 Compare June 24, 2025 17:17

tristan957 reviewed Jun 24, 2025

View reviewed changes

Comment thread src/apprt/action.zig Outdated

jcollie force-pushed the apprt-action-open-url branch 2 times, most recently from c6821f6 to ad845dc Compare July 6, 2025 06:09

jcollie changed the title ~~core/gtk/glfw: open urls using an apprt action instead of doing it directly~~ core/gtk: open urls using an apprt action instead of doing it directly Jul 6, 2025

jcollie added 2 commits July 6, 2025 15:02

better ABI check for apprt.Action.CValue

70a2a0a

mitchellh force-pushed the apprt-action-open-url branch from ad845dc to 70a2a0a Compare July 6, 2025 22:02

mitchellh reviewed Jul 6, 2025

View reviewed changes

Fallback to cross-platform minimal open when apprt is not available

cbcb0b7

mitchellh approved these changes Jul 6, 2025

View reviewed changes

mitchellh mentioned this pull request Jul 6, 2025

macOS: Use system API to open links #5256

Closed

mitchellh merged commit 78e861b into ghostty-org:main Jul 6, 2025

jcollie deleted the apprt-action-open-url branch July 6, 2025 22:20

github-actions Bot added this to the 1.2.0 milestone Jul 6, 2025

codemedic mentioned this pull request Sep 25, 2025

Unable to open web URLs pkgforge-dev/ghostty-appimage#97

Closed

Conversation

jcollie commented Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tristan957 commented Feb 25, 2025

Uh oh!

mitchellh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jcollie commented Feb 25, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tristan957 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tristan957 commented Jun 24, 2025

Uh oh!

tristan957 commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jcollie commented Jun 24, 2025

Uh oh!

jcollie commented Jun 24, 2025

Uh oh!

pluiedev commented Jun 24, 2025

Uh oh!

tristan957 commented Jun 24, 2025

Uh oh!

tristan957 commented Jun 24, 2025

Uh oh!

jcollie commented Jun 24, 2025

Uh oh!

mitchellh Jul 6, 2025

Choose a reason for hiding this comment

Uh oh!

mitchellh commented Jul 6, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jcollie commented Feb 25, 2025 •

edited

Loading

tristan957 commented Jun 24, 2025 •

edited

Loading