Repository navigation
Conversation
`+ssh` passed `-o SetEnv=TERM=...` to ssh. ssh only uses the first SetEnv it finds, so the one on the command line replaced every SetEnv entry in the user's ssh config. This brings back the bug that #11518 fixed in the old shell integration wrapper, now in `+ssh` (#12582). `TERM` was also only set with `--forward-env`, so `--forward-env=false` (what `ssh-terminfo`-only users get) left the inherited `TERM=xterm-ghostty` in place even when the terminfo install failed. ssh sends the SetEnv entries in the user's ssh config again, and a failed terminfo install falls back to `xterm-256color` like it did in 1.3.1, no matter which `ssh-*` features are enabled. `TERM` is now set in the environment of the ssh process instead of with SetEnv, the same way the 1.3.1 wrapper did. ssh sends `TERM` on its own when it opens a remote terminal, so the server doesn't need `AcceptEnv TERM`. This happens whenever `--forward-env` or `--terminfo` is enabled. With both disabled, ssh runs with the user's environment unchanged. The `+ssh` help is updated to explain how `TERM` is chosen. Docs: https://man.openbsd.org/ssh_config#SetEnv
jparise
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
+sshpassed-o SetEnv=TERM=...to ssh. ssh only uses the first SetEnv it finds, so the one on the command line replaced every SetEnv entry in the user's ssh config. This brings back the bug that #11518 fixed in the old shell integration wrapper, now in+ssh(#12582).TERMwas also only set with--forward-env, so--forward-env=false(whatssh-terminfo-only users get) left the inheritedTERM=xterm-ghosttyin place even when the terminfo install failed.ssh sends the SetEnv entries in the user's ssh config again, and a failed terminfo install falls back to
xterm-256colorlike it did in 1.3.1, no matter whichssh-*features are enabled.TERMis now set in the environment of the ssh process instead of with SetEnv, the same way the 1.3.1 wrapper did. ssh sendsTERMon its own when it opens a remote terminal, so the server doesn't needAcceptEnv TERM. This happens whenever--forward-envor--terminfois enabled. With both disabled, ssh runs with the user's environment unchanged. The+sshhelp is updated to explain howTERMis chosen.Docs: https://man.openbsd.org/ssh_config#SetEnv