Repository navigation
termio: send the config change color scheme report directly - #14834
Merged
mitchellh merged 1 commit intoOct 26, 2026
Merged
Conversation
StreamHandler.changeConfig queued a color_scheme_report message into the termio mailbox. changeConfig runs on the io thread, which is the only reader of that mailbox, so when the mailbox was full (for example, from a burst of query replies queued by the reader thread) the io thread blocked forever pushing to itself. Every other thread then blocked on its next send to the same mailbox, freezing Ghostty on a config reload. Write the report from Termio.changeConfig instead, using the same colorSchemeReportLocked the message handler uses. The report still follows the config update in order with other output. Fixes: ghostty-org#14833
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StreamHandler.changeConfig queued a color_scheme_report message into the termio mailbox. changeConfig runs on the io thread, which is the only reader of that mailbox, so when the mailbox was full (for example, from a burst of query replies queued by the reader thread) the io thread blocked forever pushing to itself. Every other thread then blocked on its next send to the same mailbox, freezing Ghostty on a config reload.
Write the report from Termio.changeConfig instead, using the same colorSchemeReportLocked the message handler uses. The report still follows the config update in order with other output.
Fixes: #14833
AI disclosure: Claude Code was used in the preparation of this PR.