Repository navigation
empty cli or config args reset the value to the default - #1368
Merged
Merged
Conversation
Fixes #1367 We previously special-cased optionals but we should do better and have this reset ANY type to the defined default value on the struct.
pluiedev
pushed a commit
that referenced
this pull request
May 14, 2026
After #1368, `command-palette-entry=` will no longer clear the entries like the documentation says. Since i couldn't find an existing issue or discussion about this, I assume no one is actually using it. So I put 1.4.0 here, lemme know if you want to change it to 1.3.2. > I basically copied the `keybind` parsing code and doc.
pluiedev
added a commit
that referenced
this pull request
May 14, 2026
After #1368, `command-palette-entry=` will no longer clear the entries like the documentation says. Since i couldn't find an existing issue or discussion about this, I assume no one is actually using it. So I put 1.4.0 here, lemme know if you want to change it to 1.3.2. > I basically copied the `keybind` parsing code and doc.
xi-guan
pushed a commit
to xi-guan/cmux-ghostty
that referenced
this pull request
May 18, 2026
After ghostty-org#1368, `command-palette-entry=` will no longer clear the entries like the documentation says. Since i couldn't find an existing issue or discussion about this, I assume no one is actually using it. So I put 1.4.0 here, lemme know if you want to change it to 1.3.2. > I basically copied the `keybind` parsing code and doc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1367
We previously special-cased optionals but we should do better and have this reset ANY type to the defined default value on the struct.