Repository navigation
Conversation
5 tasks done
Contributor
Author
|
I also ran our ghostty-bench on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new config
scrollback-limit-linesto limit scrollback by lines instead of bytes. This also renamesscrollback-limittoscrollback-limit-bytesto make it clear what it does but we have a compatibility entry so old configurations will continue to work, so its not breaking.This is NOT exclusive to
scrollback-limit-bytes. When both are set, then the first limit reached is used. Since lines is affected by viewport size and bytes are affected by entries (more styles, more graphemes, etc.), they serve somewhat different purposes and it might be useful to set both.The default remains 50MB of bytes, unlimited lines.
This is not exposed to libghostty yet. I have that coming as a follow up change.