Repository navigation
fix: apply variation selectors to preceding codepoint - #12596
Merged
Merged
Conversation
noib3
force-pushed
the
vs-to-prev-codepoint
branch
from
May 6, 2026 08:44
dd51445 to
f105aeb
Compare
This fixes a bug where the variation selectors (VS15 & VS16) were checked against the first codepoint in a cell instead of the previous codepoint in the cell's grapheme cluster, causing them to be dropped if the first codepoint was not a valid base.
noib3
force-pushed
the
vs-to-prev-codepoint
branch
from
May 6, 2026 08:46
f105aeb to
3f11e69
Compare
5 tasks done
mitchellh
approved these changes
May 22, 2026
mitchellh
left a comment
mitchellh
left a comment
Contributor
There was a problem hiding this comment.
This makes sense! Thanks for the test. Approved pending CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the variation selectors (VS15 & VS16) were checked against the first codepoint in a cell instead of the previous codepoint in the cell's grapheme cluster, causing them to be dropped if that first codepoint was not a valid base.