Repository navigation
cli: +edit-config works properly when editor command contains arguments - #11898
Merged
Merged
Conversation
If `$EDITOR` or `$VISUAL` contained arguments, not just the path to an editor (e.g. `zed --new`) `+edit-config` would fail because we were treating the whole command as a path. Instead, wrap the command with `/bin/sh -c <command>` so that the shell can separate the path from the arguments. Fixes ghostty-org#11897
Member
Author
|
This was apparently fixed once before in #8901 but that must have only been applied to 1.2.x and not to 1.3.x. |
3 tasks done
mitchellh
approved these changes
Mar 28, 2026
|
Any chance this could get released soon? It's broken with Zed ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
$EDITORor$VISUALcontained arguments, not just the path to an editor (e.g.zed --new)+edit-configwould fail because we were treating the whole command as a path. Instead, wrap the command with/bin/sh -c <command>so that the shell can separate the path from the arguments.Fixes #11897