Repository navigation
gtk: Open URIs with portals - #11754
Merged
Merged
Conversation
- Token is formatted without allocation - Reusable function for formatToken - Tests in portal.zig are actuall included now
Contributor
|
Hi @tdgroot, thanks for your interest in contributing! This project requires that pull request authors are vouched, and you are not in the list of vouched users. This PR will be closed automatically. See https://github.com/ghostty-org/ghostty/blob/main/CONTRIBUTING.md for more details. |
Contributor
|
!vouch |
Merged
ghostty-vouch Bot
added a commit
that referenced
this pull request
Mar 22, 2026
Triggered by [comment](#11754 (comment)) from @mitchellh. Vouch: @tdgroot Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
jcollie
requested changes
Mar 23, 2026
jcollie
left a comment
jcollie
left a comment
Member
There was a problem hiding this comment.
One minor nit, otherwise LGTM.
anhoder
pushed a commit
to anhoder/ghostty
that referenced
this pull request
Mar 28, 2026
Triggered by [comment](ghostty-org#11754 (comment)) from @mitchellh. Vouch: @tdgroot Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
christmic
pushed a commit
to christmic/Sylvander
that referenced
this pull request
Aug 12, 2026
Triggered by [comment](ghostty-org/ghostty#11754 (comment)) from @mitchellh. Vouch: @tdgroot Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of the solid work done by @jcollie in PR #7864. I checked with him if I could take over to continue the implementation.
His changes of last year have been adapted to be compatible with the current GTK implementation. Aside from just "making it work", I also dived into the portals and OpenURI implementation and made some improvements there.
Notable improvements were:
Fixes #5991