Skip to content

config: clear command-palette-entry like keybind - #12682

Merged
pluiedev merged 1 commit into
ghostty-org:mainfrom
bo2themax:push-8aba4de0
May 14, 2026
Merged

pluiedev merged 1 commit into
ghostty-org:mainfrom
bo2themax:push-8aba4de0

Conversation

@bo2themax

Copy link
Copy Markdown
Member

After #1368, command-palette-entry= will no longer clear the entries like the documentation says. Since i couldn't find an existing issue or discussion about this, I assume no one is actually using it. So I put 1.4.0 here, lemme know if you want to change it to 1.3.2.

I basically copied the keybind parsing code and doc.

After ghostty-org#1368, `command-palette-entry=` will no longer clear the entries like the documentation says. Since i couldn't find an existing issue or discussion about this, I assume no one is actually using it. So I put 1.4.0 here, lemme know if you want to change it to 1.3.2.

> I basically copied the `keybind` parsing code and doc.
@bo2themax
bo2themax requested review from 00-kat and jcollie May 14, 2026 17:52

@pluiedev pluiedev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense, yeah - thanks!

@jcollie jcollie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Stick with 1.4 as the milestone as this is new functionality.

@pluiedev pluiedev added this to the 1.4.0 milestone May 14, 2026
@pluiedev
pluiedev merged commit 96848d7 into ghostty-org:main May 14, 2026
91 checks passed
@bo2themax
bo2themax deleted the push-8aba4de0 branch May 14, 2026 18:31
@00-kat

00-kat commented May 14, 2026 •

Copy link
Copy Markdown
Contributor

Bit late but seconded; nota bene:

Since i couldn't find an existing issue or discussion about this

Not everyone reads docs in any logical order; if someone just wanted to get rid of the command palette entries, they're more likely to copy paste from its documentation than to read the docs on the general syntax which they undoubtedly needed to have understood, especially given Ghostty's syntax is deceptively simple.

Edit: even of the people who do, it's definitely possible it's missed due to the already complicated syntax of command-palette-entry. And that assumes people report minor UX infelicities, which isn't particularly common either.

But yeah I don't think anyone actually used this, à la keybind = and keybind = clear. It definitely deserves a noticeable mention in the breaking changes section of the release notes though, since it'd be extremely confusing for the potential few who do use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants