Repository navigation
custom-shader broken on Intel Mac with 1.2.0 release
#8695
Issue DescriptionIt seems that I have tried some shaders before, just for fun, on 1.1.3 version, like the After updating to 1.2.0, Maybe i'm using an invalid shader, let's try the cursor shader used in the 1.2.0 release note, nah, not working, black screen, same behavior ! I have asked in linkarzu discord, it's working fine on last release with M1 Mac, linkarzu confirm it. After a long debug, with this sample, it seems that Expected BehaviorDraw the text and cursor but no visual-effect: void mainImage(out vec4 fragColor, in vec2 fragCoord) {
vec2 uv = fragCoord / iResolution.xy;
vec3 base = texture(iChannel0, uv).rgb;
fragColor = vec4(base, 1.0);
}
Draw the text and cursor with inverted colors(black to white ...): void mainImage(out vec4 fragColor, in vec2 fragCoord) {
vec2 uv = fragCoord / iResolution.xy;
vec3 base = texture(iChannel0, uv).rgb;
fragColor = vec4(1.0 - base, 1.0);
}
// Original shader collected from: https://www.shadertoy.com/view/WsVSzV
// Licensed under Shadertoy's default since the original creator didn't provide any license. (CC BY NC SA 3.0)
// Slight modifications were made to give a green-ish effect.
// This shader was modified by April Hall (arithefirst)
// Sourced from https://github.com/m-ahdal/ghostty-shaders/blob/main/retro-terminal.glsl
// Changes made:
// - Removed tint
// - Made the boundaries match ghostty's background color
float warp = 0.25; // simulate curvature of CRT monitor
float scan = 0.50; // simulate darkness between scanlines
void mainImage(out vec4 fragColor, in vec2 fragCoord)
{
// squared distance from center
vec2 uv = fragCoord / iResolution.xy;
vec2 dc = abs(0.5 - uv);
dc *= dc;
// warp the fragment coordinates
uv.x -= 0.5; uv.x *= 1.0 + (dc.y * (0.3 * warp)); uv.x += 0.5;
uv.y -= 0.5; uv.y *= 1.0 + (dc.x * (0.4 * warp)); uv.y += 0.5;
// determine if we are drawing in a scanline
float apply = abs(sin(fragCoord.y) * 0.25 * scan);
// sample the texture
vec3 color = texture(iChannel0, uv).rgb;
// mix the sampled color with the scanline intensity
fragColor = vec4(mix(color, vec3(0.0), apply), 1.0);
}
Actual BehaviorBlack screen; text and cursor invisible, command still interpreted(trying void mainImage(out vec4 fragColor, in vec2 fragCoord) {
vec2 uv = fragCoord / iResolution.xy;
vec3 base = texture(iChannel0, uv).rgb;
fragColor = vec4(base, 1.0);
}
White screen this time instead of black; text and cursor invisible, command still interpreted(trying void mainImage(out vec4 fragColor, in vec2 fragCoord) {
vec2 uv = fragCoord / iResolution.xy;
vec3 base = texture(iChannel0, uv).rgb;
fragColor = vec4(1.0 - base, 1.0);
}
Black screen with // Original shader collected from: https://www.shadertoy.com/view/WsVSzV
// Licensed under Shadertoy's default since the original creator didn't provide any license. (CC BY NC SA 3.0)
// Slight modifications were made to give a green-ish effect.
// This shader was modified by April Hall (arithefirst)
// Sourced from https://github.com/m-ahdal/ghostty-shaders/blob/main/retro-terminal.glsl
// Changes made:
// - Removed tint
// - Made the boundaries match ghostty's background color
float warp = 0.25; // simulate curvature of CRT monitor
float scan = 0.50; // simulate darkness between scanlines
void mainImage(out vec4 fragColor, in vec2 fragCoord)
{
// squared distance from center
vec2 uv = fragCoord / iResolution.xy;
vec2 dc = abs(0.5 - uv);
dc *= dc;
// warp the fragment coordinates
uv.x -= 0.5; uv.x *= 1.0 + (dc.y * (0.3 * warp)); uv.x += 0.5;
uv.y -= 0.5; uv.y *= 1.0 + (dc.x * (0.4 * warp)); uv.y += 0.5;
// determine if we are drawing in a scanline
float apply = abs(sin(fragCoord.y) * 0.25 * scan);
// sample the texture
vec3 color = texture(iChannel0, uv).rgb;
// mix the sampled color with the scanline intensity
fragColor = vec4(mix(color, vec3(0.0), apply), 1.0);
}
Reproduction Steps~/.config/ghostty/config: shaders/sample.glsl: void mainImage(out vec4 fragColor, in vec2 fragCoord) {
vec2 uv = fragCoord / iResolution.xy;
vec3 base = texture(iChannel0, uv).rgb;
fragColor = vec4(base, 1.0);
}shaders/inverted.glsl: void mainImage(out vec4 fragColor, in vec2 fragCoord) {
vec2 uv = fragCoord / iResolution.xy;
vec3 base = texture(iChannel0, uv).rgb;
fragColor = vec4(1.0 - base, 1.0);
}shaders/bettercrt.glsl: // Original shader collected from: https://www.shadertoy.com/view/WsVSzV
// Licensed under Shadertoy's default since the original creator didn't provide any license. (CC BY NC SA 3.0)
// Slight modifications were made to give a green-ish effect.
// This shader was modified by April Hall (arithefirst)
// Sourced from https://github.com/m-ahdal/ghostty-shaders/blob/main/retro-terminal.glsl
// Changes made:
// - Removed tint
// - Made the boundaries match ghostty's background color
float warp = 0.25; // simulate curvature of CRT monitor
float scan = 0.50; // simulate darkness between scanlines
void mainImage(out vec4 fragColor, in vec2 fragCoord)
{
// squared distance from center
vec2 uv = fragCoord / iResolution.xy;
vec2 dc = abs(0.5 - uv);
dc *= dc;
// warp the fragment coordinates
uv.x -= 0.5; uv.x *= 1.0 + (dc.y * (0.3 * warp)); uv.x += 0.5;
uv.y -= 0.5; uv.y *= 1.0 + (dc.x * (0.4 * warp)); uv.y += 0.5;
// determine if we are drawing in a scanline
float apply = abs(sin(fragCoord.y) * 0.25 * scan);
// sample the texture
vec3 color = texture(iChannel0, uv).rgb;
// mix the sampled color with the scanline intensity
fragColor = vec4(mix(color, vec3(0.0), apply), 1.0);
}Ghostty LogsGhostty VersionOS Version InformationMacOS Sequoia 15.6.1(Intel Mac) (Linux only) Display ServerNone (Linux only) Desktop Environment/Window ManagerNo response Minimal Ghostty Configurationcustom-shader = shaders/sample.glslAdditional Relevant ConfigurationNo response I acknowledge that:
|
Replies: 4 comments 12 replies
|
I don't have an intel mac anymore to test this. My suggestion is we simply disable custom shaders on intel macs, we're probably dropping support next year anyways. Can anyone else with an Intel mac confirm custom shaders do not wor? |
|
I have just downgraded to 1.1.3 since i can't enable cursor trail feature, + the 1.2.0 destroyed my icons, i'm using Operator Mono font, need to force PS: |
|
There's a lot of unrelated information in this. My takeaway is there is no new information here, the shaders don't work. |
|
Let's skip the icon rendering issue, i will create a separate issue for, which information you need for shaders ? |
|
None, I'm not planning on fixing it. I'm dropping Intel Mac support. |
|
Thanks for your detailed report, @flashios09. I'm experiencing all the same symptoms you are — custom shaders used to work on Intel macOS Sequoia, but with the 1.2.0 release, they don't work anymore. I also experience a black screen when enabling custom shaders. When I try the new cursor_blaze shader, the text disappears into blackness even though I can see the orange "dynamic trail" zipping around. @mitchellh, that's too bad you want to deprecate Intel releases. I'm stuck on the Intel model for a work laptop. I want to promote Ghostty to other co-workers during screensharing calls, but I guess the fancy shaders won't be an option anymore. |
|
I don’t want to but it’s impractical for me to have to find an Intel machine (I haven’t had one in 5 years) to debug these issues, and working over Remote Desktop is a terrible experience. If someone can resolve this issue I’d be happy to merge the fix. What I really would love is an Intel Mac maintainer, if such a person is interested. But I think I can’t in good faith do this myself anymore and I don’t want to falsely lead people to expect the same quality there of I’m unable to test it myself. |
|
I don't know if this will fix the Intel issues but I've found a Metal API validation issue I plan on fixing for 1.2.1 that only occurs with cursor shaders. I have a feeling this might fix it, but can't test. I'll report back when we have a test binary maybe someone here can try it. 😄 |
|
Can someone with an Intel machine try the latest tip release and see if this is resolved? cc @flashios09 @spiritphyz |
|
Tout de suite :) |
I can confirm that shaders/bettercrt.glsl: shaders/invert.glsl: PS: |
|
Awesome, I bet you it works. Happy to see this resolved! |
PRs: #8751 and #8749