Fix bug in zsh ssh-terminfo integration

[mihi314]

What do you want to change?

I want to contribute the following patch: mihi314@875985d

--- a/src/shell-integration/zsh/ghostty-integration
+++ b/src/shell-integration/zsh/ghostty-integration
@@ -315,7 +315,7 @@ _ghostty_deferred_init() {
                 ssh_cpath_dir=$(mktemp -d "/tmp/ghostty-ssh-$ssh_user.XXXXXX" 2>/dev/null) || ssh_cpath_dir="/tmp/ghostty-ssh-$ssh_user.$$"
                 ssh_cpath="$ssh_cpath_dir/socket"

-                if print "$ssh_terminfo" | command ssh "${ssh_opts[@]}" -o ControlMaster=yes -o ControlPath="$ssh_cpath" -o ControlPersist=60s "$@" '
+                if builtin print -r "$ssh_terminfo" | command ssh "${ssh_opts[@]}" -o ControlMaster=yes -o ControlPath="$ssh_cpath" -o ControlPersist=60s "$@" '
                   infocmp xterm-ghostty >/dev/null 2>&1 && exit 0
                   command -v tic >/dev/null 2>&1 || exit 1
                   mkdir -p ~/.terminfo 2>/dev/null && tic -x - 2>/dev/null && exit 0

With zsh, when installing the ghostty terminfo on a server via the ssh-terminfo shell integration, parts of the terminfo get mangled. In particular, the newline escape sequence in

> infocmp -0 -x xterm-ghostty | grep ind=
 ...,ind=\n,indn=...

gets interpreted by print as a literal newline, which then just gets ignored / does not have the intended effect.

You can directly demonstrate this locally. This outputs a host of error messages:

ssh_terminfo=$(infocmp -0 -x xterm-ghostty 2>/dev/null)
print "$ssh_terminfo" | tic -x -

Whereas
print -r "$ssh_terminfo" | tic -x -
or
infocmp -0 -x xterm-ghostty | tic -x -
work without issue.

(Documentation for the -r flag of print is here)

Why do you want to make this change?

Without this, the installed terminfo only works partially. For example the output of htop, which is where I first noticed this issue, is fully messed up and unreadable.

I've found a PR for fish (#7960) where a somewhat similar bug was fixed. But nothing for zsh.

Instead of vouching for me, I'd also be fine with somebody else committing this change, if that makes things easier.

Ghostty Version

Ghostty 1.2.3-arch3

Version
  - version: 1.2.3-arch3
  - channel: tip
Build Config
  - Zig version   : 0.14.1
  - build mode    : builtin.OptimizeMode.ReleaseFast
  - app runtime   : apprt.Runtime.gtk
  - font engine   : font.main.Backend.fontconfig_freetype
  - renderer      : renderer.generic.Renderer(renderer.OpenGL)
  - libxev        : io_uring
  - kernel version: 6.18.6-arch1-1
  - desktop env   : gnome
  - GTK version   :
    build         : 4.20.3
    runtime       : 4.20.3
  - libadwaita    : enabled
    build         : 1.8.4
    runtime       : 1.8.4
  - libX11        : enabled
  - libwayland    : enabled

I acknowledge that:

• I have read the Contributing Guide and understand the contribution process.
• I have read and agree to follow the AI Usage Policy.
• I wrote this vouch request myself, in my own voice, without AI generating it.

[mitchellh]

!vouch