Repository navigation
fix(prepare)!: Fail when no target bumps the version, and bump nuget VersionPrefix - #923
Merged
Merged
Conversation
Fixes #825 Co-Authored-By: Burak Yigit Kaya <burak.kaya@sentry.io>
If every bumpable target skips detection, prepare used to warn and continue, releasing artifacts with the previous version. Fail instead. Refs #825 Co-Authored-By: Burak Yigit Kaya <burak.kaya@sentry.io>
sentry-junior
Bot
changed the title
Contributor
|
BYK
approved these changes
Oct 22, 2026
BYK
enabled auto-merge (squash)
October 22, 2026 13:39
8 tasks done
jamescrosswell
pushed a commit
to getsentry/sentry-dotnet
that referenced
this pull request
Oct 22, 2026
* ci: Use craft's built-in version bumping Craft 3.0.0 bumps <VersionPrefix> in Directory.Build.props itself and fails prepare if no version gets bumped (getsentry/craft#923), so the custom bump-version script is no longer needed. Co-Authored-By: Burak Yigit Kaya <burak.kaya@sentry.io> * ci: Move to craft's changelog and versioning policy keys Co-Authored-By: Burak Yigit Kaya <burak.kaya@sentry.io> * ci: Use the craft v3 floating tag Co-Authored-By: Burak Yigit Kaya <burak.kaya@sentry.io> --------- Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com> Co-authored-by: Burak Yigit Kaya <burak.kaya@sentry.io>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes for #825, where a sentry-dotnet release went out with the previous version on every
.nupkg.nuget
VersionPrefix: the nuget auto-bumper already detectsDirectory.Build.props, but it only rewrote<Version>,<PackageVersion>,<AssemblyVersion>and<FileVersion>. SDK-style repos that set<VersionPrefix>instead (e.g. sentry-dotnet) matched nothing, so the bump reported "detection failed". It now rewrites<VersionPrefix>too, matching what sentry-dotnet's ownbump-version.ps1does.Breaking:
preparefails when nothing gets bumped. When automatic version bumping is active and targets support bumping but none of them find a version to update,prepareused to log a warning and continue, committing and tagging with a stale version. It now throws aConfigurationError. Repos whose versions don't live in project files (e.g. MinVer or tag-derived versions) need to setpreReleaseCommand: ''to opt out. Configs where no target supports bumping (e.g. github-only) still just warn.Fixes #825
via BYK.
--
View Junior Session [Sentry]