Repository navigation
feat(config)!: Reject changelog path settings without workspaces - #922
Merged
Merged
Conversation
changelog.includePaths and changelog.unownedPaths only affect release workspace ownership. Without workspaces Craft silently ignored them, so reject them during validation instead. Co-Authored-By: BYK <burak.kaya@sentry.io>
Contributor
|
BYK
approved these changes
Oct 22, 2026
8 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog.includePathsandchangelog.unownedPathsonly change which release workspace owns a path. A configuration withoutworkspaceshas no ownership to change, so Craft accepted both settings and silently ignored them. That's how the objectstore case behind #920 started:includePathsinclients/.craft.ymllooked like it should work, but did nothing.Validation now rejects either setting in the top-level
changelogwhen noworkspacesare defined:When
workspacesexist, top-level values are still allowed because workspaces inherit them.This is a breaking change for configs that set these keys without workspaces. A GitHub code search for
includePathsin.craft.ymlfinds only getsentry/toolkit, which uses it inside a workspace. Repos like objectstore that need "only these directories" can define a workspace withunownedPaths: excludeplusincludePaths(#921). This replaces the approach in #920.via BYK.
--
View Junior Session in Sentry