Repository navigation
feat(changelog): Ground AI summaries in PR descriptions - #918
Conversation
Co-Authored-By: Aditya Mathur <aditya.mathur@sentry.io>
|
MathurAditya724
left a comment
There was a problem hiding this comment.
Reviewed all five changed files and the surrounding generation, hierarchy, provider and rendering paths at fc2585d. The Markdown-parser update fixes the fence/comment cases from the earlier revision. The 150 affected tests, TypeScript check and focused ESLint check pass locally; current CI, including live summarizer replay and five-platform artifact verification, also passes. One actionable issue remains in shortcode normalization, noted inline.
MathurAditya724
left a comment
There was a problem hiding this comment.
Reviewed the final head and verified the fix for the reported shortcode issue: inline-code configuration values are retained, with regression coverage. No remaining blocking findings. All 28 applicable CI checks pass, including live summarizer replay and five-platform artifact verification; the 150 focused tests, typecheck, lint and build also pass locally.
Category summaries in the 3.0.0 release preview were vague ("Release communication…", "Internal maintenance…"), and the breaking-change summary didn't say why the change was breaking. The model only had PR titles to work with, and the prompt pushed category summaries toward abstract themes.
Changelog Entrysection or#body-in-changelogdon't get one, since their curated text is already the entry.serializeChangelognow passes each group's source PRs alongside its rendered items. The important-title and description lookups both come from that one list, so there's no more index-offset merging.I left reasoning level / model settings alone. Whether those need tuning is easier to judge once a real release has run with the richer input.
Closes #917
via adm.
--
View Junior Session [Sentry]