Skip to content

fix: Allow Git identity environment for commits - #896

Merged
BYK merged 1 commit into
masterfrom
fix/release-git-env-allowlist
Oct 7, 2026
Merged

BYK merged 1 commit into
masterfrom
fix/release-git-env-allowlist

Conversation

@BYK

@BYK BYK commented Oct 7, 2026

Copy link
Copy Markdown
Member

Summary

  • Allow only Git author/committer identity variables through simple-git 4's environment guard in Craft Git clients.
  • Keep other guarded Git environment variables blocked.
  • Add a real-Git regression that creates a commit through getGitClient() with no configured identity, and update the clone client assertion.

The dogfooding release already supplies GIT_AUTHOR_NAME and related identity variables, but simple-git 4 strips them by default. This caused the release commit to fail with an empty author name.

Validation

  • pnpm test -- --printConsoleTrace (62 files; 1,261 passed, 1 skipped)
  • pnpm typecheck
  • pnpm lint
  • pnpm format:check
  • pnpm build (source-map upload skipped because SENTRY_AUTH_TOKEN is unset)
  • pnpm docs:build (29 pages)

@BYK
BYK merged commit f1371df into master Oct 7, 2026
21 of 22 checks passed
@BYK
BYK deleted the fix/release-git-env-allowlist branch October 7, 2026 19:15

This branch was successfully deployed

1 active deployment
false — 0c080e2f Deployed Oct 7, 2026 by BYK via Build #2984
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant