Repository navigation
fix(mouse): work around Ghostty false motion press bug - #1051
Merged
Merged
Conversation
Ghostty may emit mouse motion events that incorrectly indicate a button is pressed even when no corresponding press occurred. Ignore those packets to avoid creating a synthetic button-down state.
Contributor
Author
|
This change is a workaround for the Ghostty bug described in #1045. My main goal is not necessarily to have this PR merged, but rather to see the issue properly fixed on the Ghostty side: https://github.com/ghostty-org/ghostty/discussions/12078 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1051 +/- ##
==========================================
- Coverage 86.27% 86.18% -0.10%
==========================================
Files 46 46
Lines 5057 5060 +3
==========================================
- Hits 4363 4361 -2
- Misses 537 539 +2
- Partials 157 160 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gdamore
approved these changes
Apr 6, 2026
gdamore
left a comment
Owner
There was a problem hiding this comment.
I think we had logic like this that I may have dropped in the past.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ghostty may emit mouse motion events that incorrectly indicate a button is pressed even when no corresponding press occurred. Ignore those packets to avoid creating a synthetic button-down state.