Skip to content

MPI fixes (macOS build/link flags), oneAPI ifort->ifx switch; turn off MSMPI CI - #976

Merged
perazz merged 5 commits into
fortran-lang:mainfrom
perazz:fix_cpp_linker
Dec 28, 2023
Merged

MPI fixes (macOS build/link flags), oneAPI ifort->ifx switch; turn off MSMPI CI#976
perazz merged 5 commits into
fortran-lang:mainfrom
perazz:fix_cpp_linker

Conversation

@perazz

@perazz perazz commented Dec 13, 2023

Copy link
Copy Markdown
Member

@fortran-lang/admins

Comment thread src/fpm_meta.f90
@perazz

perazz commented Dec 13, 2023

Copy link
Copy Markdown
Member Author

It seems like something is now failing in the oneAPI CI (classic intel compilers deprecated?). I see that no fpm actions have been run for the past few months, so that might be the case. I will do some more tests

@perazz perazz changed the title Sanitize MPI build/link flags; fix MSMPI CI MPI fixes (macOS build/link flags), oneAPI ifort->ifx switch; fix MSMPI CI Dec 13, 2023

@henilp105 henilp105 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @perazz , Looks Good to me.

@gnikit gnikit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, there are quite a few changes though. I left some comments inline mostly with clean-up, underlying code seems good.

To make review faster, when possible, could we try and stick with 1 fix/feature per PR. One of the reasons why I delayed reviewing this is because fixes kept being added in this PR.

Comment thread src/fpm_environment.f90 Outdated
Comment thread src/fpm_meta.f90 Outdated
Comment thread src/fpm_meta.f90 Outdated
@perazz

perazz commented Dec 21, 2023

Copy link
Copy Markdown
Member Author

One of the reasons why I delayed reviewing this is because fixes kept being added in this PR.

I agree, committed to it. Unfortunately new issues kept arising in the CI as I was fixing the macOS flags

@gnikit gnikit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@perazz

perazz commented Dec 24, 2023

Copy link
Copy Markdown
Member Author

Thank you @gnikit @henilp105 @ivan-pi for the reviews, let's merge in a few days if there are no more comments.

@gnikit

gnikit commented Dec 25, 2023

Copy link
Copy Markdown
Member

I will have a look in the windows metapackages CI to see if we can get it to work more reliably. If the Action is not robust yet, it might be worth disabling whilst troubleshooting to merge in main.

@perazz perazz changed the title MPI fixes (macOS build/link flags), oneAPI ifort->ifx switch; fix MSMPI CI MPI fixes (macOS build/link flags), oneAPI ifort->ifx switch; turn off MSMPI CI Dec 28, 2023
@perazz

perazz commented Dec 28, 2023

Copy link
Copy Markdown
Member Author

There are two approvals, so I will merge this one.

@perazz
perazz merged commit c6ef3c4 into fortran-lang:main Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Latest Xcode update has broken MPI builds on macOS

4 participants