MPI fixes (macOS build/link flags), oneAPI ifort->ifx switch; turn off MSMPI CI - #976
Conversation
|
It seems like something is now failing in the oneAPI CI (classic intel compilers deprecated?). I see that no fpm actions have been run for the past few months, so that might be the case. I will do some more tests |
6a063a4 to
07bf22c
Compare
gnikit
left a comment
There was a problem hiding this comment.
Looks good, there are quite a few changes though. I left some comments inline mostly with clean-up, underlying code seems good.
To make review faster, when possible, could we try and stick with 1 fix/feature per PR. One of the reasons why I delayed reviewing this is because fixes kept being added in this PR.
I agree, committed to it. Unfortunately new issues kept arising in the CI as I was fixing the macOS flags |
|
Thank you @gnikit @henilp105 @ivan-pi for the reviews, let's merge in a few days if there are no more comments. |
|
I will have a look in the windows metapackages CI to see if we can get it to work more reliably. If the Action is not robust yet, it might be worth disabling whilst troubleshooting to merge in main. |
|
There are two approvals, so I will merge this one. |
ifortwithifxin oneAPI runner. Fpm build now fails due to this issue-check all,nouninit(see above)@fortran-lang/admins