Fix failing tests with Intel compiler - #901
Merged
Merged
Conversation
arteevraina
approved these changes
May 21, 2023
arteevraina
left a comment
arteevraina
left a comment
Member
There was a problem hiding this comment.
Thankyou @perazz . Looks fine to me.
awvwgk
reviewed
May 21, 2023
awvwgk
left a comment
awvwgk
left a comment
Member
There was a problem hiding this comment.
Thanks for sharing. Looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address #898.
With this PR, not only fpm is properly built, but all tests succeed with both gfortran and ifort.
more discussion here and there on the Fortran Discourse.
the Metapackage CI (#859) does not require fpm to run tests yet due to this issue, but we may enable them again once this PR is merged.
cc @henilp105 @arteevraina @minhqdao @awvwgk @certik