Fix multiple installs - #888
Merged
Merged
Conversation
Member
Author
|
A quick check should be enough on this one. Thank you @minhqdao @arteevraina @henilp105 |
arteevraina
approved these changes
Apr 24, 2023
Member
Author
|
Thank you @henilp105 @arteevraina, I think I can merge this now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #886. As correctly pointed out there, fpm should never move files away from its internal folders as that will break local storage in unpredictable ways.
I believe usage of
movecommands was motivated by the fact that, if we want to install a package again in a same folder where it exists already, some OSs may request the user prompt when overwriting files.I suggest (for
installonly) to force-copy instead.cc: @awvwgk @henilp105 @arteevraina @minhqdao @freevryheid @egiovan I'd kindly ask any of you a quick review before merging, thank you in advance.