feat: default profile support - #1244
Merged
Merged
Conversation
Remove the unused `default` logical flag from feature_config_t. Add support for a "default" profile whose features are automatically applied alongside the debug and release profiles, but not when a custom profile or explicit features are requested.
- default-profile-with-debug: default features applied with --profile debug - default-profile-with-release: default features applied with --profile release - default-profile-implicit-debug: default features applied with no explicit profile - default-profile-skipped-custom: default features NOT applied with custom profile
Add example package demonstrating the default profile behavior: - default profile features applied with debug/release profiles - default profile features skipped with custom profiles - default profile features applied with no explicit profile Add integration tests in ci/test_features.sh.
perazz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"default"profile whose features are automatically applied alongside thedebugandreleaseprofiles--featuresare requestedThis allows users to define baseline features (e.g. platform-specific flags) that are always included with standard debug/release builds:
Behavior
fpm buildfpm build --profile debugfpm build --profile releasefpm build --profile myprofilefpm build --features "f1,f2"