Skip to content

Metapackages: pkg_config backend support; HDF5 - #1055

Merged
henilp105 merged 48 commits into
fortran-lang:mainfrom
perazz:hdf5_metapackage
Aug 19, 2024
Merged

Metapackages: pkg_config backend support; HDF5#1055
henilp105 merged 48 commits into
fortran-lang:mainfrom
perazz:hdf5_metapackage

Conversation

@perazz

@perazz perazz commented Jun 24, 2024

Copy link
Copy Markdown
Member
  • pkg-config based metapackage instantiation
  • HDF5 metapackage support via pkg-config
  • testing
  • Ubuntu pkg-config is broken for hdf5-fortran: add the Fortran High-Level (hl_fortran) libraries manually (see meson)
  • oneAPI compilers: upgrade to 2024.1.0 (HDF5 build fails with <=2023), move to setup-fortran action
  • oneAPI + HDF5: install HDF5 using CMake (apt version uses gfortran only)
  • oneAPI: remove -standard-semantics from default flags: it changes module name mangling from _mp_ to _MP_ which crashes linking against external libraries (HDF5 but also MPI-code can not be built with Intel compiler when using standard flags #1034)

HDF5 comes with compiler wrappers (h5fc, h5cc, h5cxx). These are often unreliable.
For example, they do not work when the library is built with CMake for Homebrew.
So, do like meson: get hdf5 information via pkg-config.
To achieve that, implement a pkg-config backend for the metapackages.

cc: @henilp105 @arteevraina @awvwgk @gnikit @fortran-lang/fpm

@perazz
perazz force-pushed the hdf5_metapackage branch from abd64da to be78522 Compare June 24, 2024 18:48
@perazz
perazz marked this pull request as ready for review June 24, 2024 18:49
@perazz
perazz requested review from arteevraina and henilp105 July 6, 2024 14:09

@henilp105 henilp105 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @perazz , looks good to me.

@perazz perazz mentioned this pull request Jul 22, 2024
2 tasks
@perazz

perazz commented Aug 19, 2024

Copy link
Copy Markdown
Member Author

Will merge soon if there are no outstanding comments

@henilp105

Copy link
Copy Markdown
Member

Thanks @perazz , let's get this merged !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants