Repository navigation
params: remove named hardforks from bpo schedule - #35029
Merged
rjl493456442 merged 4 commits intoJul 1, 2026
Merged
Conversation
MariusVanDerWijden
requested review from
fjl,
gballet,
jwasinger,
lightclient,
rjl493456442 and
zsfelfoldi
as code owners
May 22, 2026 07:57
Member
|
Change generally looks good, but is there a spec somewhere for this? Currently 7892 and 7840 don't define this behavior. Just want to cross reference with that to verify it is correct. |
Member
Author
|
@lightclient nope, there was a discussion about it on discord, but I don't think we have a formal spec. |
| // a loud warning but do not abort loading — the blob schedule for those forks | ||
| // inherits from the most recent preceding BPO entry. | ||
| func (b *BlobScheduleConfig) UnmarshalJSON(data []byte) error { | ||
| type plain BlobScheduleConfig |
Member
There was a problem hiding this comment.
It's strange, json will automatically filter the unknown fields.
And what's more, this function just print some warning logs and doesn't remove the unknown fields explicitly. I feel the entire customization is unneeded.
Member
Author
There was a problem hiding this comment.
You're right, removed it
MariusVanDerWijden
force-pushed
the
bpo-config-refactor
branch
from
June 15, 2026 20:10
e8fdf4c to
820911f
Compare
rjl493456442
approved these changes
Jul 1, 2026
This was referenced Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns
into