Repository navigation
Bug: one-var separateRequires misidentifies shadowed require calls #21180
Description
Environment
Node version:
npm version:
Local ESLint version:
Global ESLint version:
Operating System:
What parser are you using?
Default (Espree)
What did you do?
Configuration
export default [
{
rules: {
"one-var": [
"error",
{
separateRequires: true,
const: "always",
},
],
},
},
];function foo(require) {
const bar = require("bar"), baz = "baz";
}What did you expect to happen?
No lint errors. The require function parameter shadows the global require, so this is not a CommonJS require() call.
What actually happened?
Split requires to be separated into a single block.
Link to Minimal Reproducible Example
Participation
- I am willing to submit a pull request for this issue.
AI acknowledgment
- I did not use AI to generate this issue report.
- (If the above is not checked) I have reviewed the AI-generated content before submitting.
Additional comments
No response
Metadata
Metadata
Assignees
Labels
Type
Projects
- Status
Activity
DMartens commentedon Aug 1, 2026
I agree that we should require that the
requireshould resolve to a global.Should we also require
sourceType: commonjs?Feel free to open a PR for this.
eslint-github-bot commentedon Aug 2, 2026
ð Hi! This issue is being addressed in pull request #21181. Thanks, @aalhadxx!
eslint-github-bot commentedon Aug 6, 2026
ð Hi! This issue is being addressed in pull request #21192. Thanks, @sethamus!
sethamus commentedon Aug 6, 2026
The rule is frozen, so I don't think we can make that change.