Skip to content

MIM-2724 Remove legacy codec from mod_muc_light - #4754

Merged
mdbrnowski merged 5 commits into
masterfrom
remove-muc-light-legacy-codec
Aug 10, 2026
Merged

mdbrnowski merged 5 commits into
masterfrom
remove-muc-light-legacy-codec

Conversation

@mdbrnowski

@mdbrnowski mdbrnowski commented Jul 28, 2026 •

Copy link
Copy Markdown
Contributor

This PR removes the deprecated codec subsystem from mod_muc_light, hard-coding the modern MUC Light codec. It deletes the legacy codec and the codec backend dispatcher, folds the modern codec into a single mod_muc_light_codec module called directly, and drops the deprecated legacy_mode option along with its tests and docs.

@mongoose-im

mongoose-im commented Jul 28, 2026 •

Copy link
Copy Markdown
Collaborator

CircleCI results for 094008a


small_tests_legacy / small_tests / ffbb523
Reports root / small


small_tests_latest / small_tests / ffbb523
Reports root / small


small_tests_latest_arm64 / small_tests / ffbb523
Reports root / small


ldap_mnesia_latest / ldap_mnesia / ffbb523
Status: 🟢 Passed
Reports root/ big
OK: 2295 / Failed: 0 / User-skipped: 1565 / Auto-skipped: 0


internal_mnesia_latest / internal_mnesia / ffbb523
Status: 🟢 Passed
Reports root/ big
OK: 2444 / Failed: 0 / User-skipped: 1416 / Auto-skipped: 0


dynamic_domains_pgsql_cets_latest / pgsql_cets / ffbb523
Status: 🟢 Passed
Reports root/ big
OK: 5154 / Failed: 0 / User-skipped: 237 / Auto-skipped: 0


dynamic_domains_pgsql_cets_legacy / pgsql_cets / ffbb523
Status: 🟢 Passed
Reports root/ big
OK: 5154 / Failed: 0 / User-skipped: 237 / Auto-skipped: 0


elasticsearch_and_cassandra_mnesia_latest / elasticsearch_and_cassandra_mnesia / ffbb523
Status: 🟢 Passed
Reports root/ big
OK: 3111 / Failed: 0 / User-skipped: 1444 / Auto-skipped: 0

mongoose_elasticsearch_SUITE:end_per_suite
{error,
  {{badrpc,
     {'EXIT',
       {#{what => event_already_registered,
        event_name => wpool_global_queue_lengths,
        labels => #{pool_type => elastic,pool_tag => default}},
        [{mongoose_instrument,set_up,3,
           [{file,
            "/home/circleci/project/src/instrument/mongoose_instrument.erl"},
          {line,114}]},
         {lists,foreach_1,2,[{file,"lists.erl"},{line,2641}]},
         {mongoose_wpool,start,5,
           [{file,
            "/home/circleci/project/src/wpool/mongoose_wpool.erl"},
          {line,162}]},
         {mongoose_wpool,'-start_configured_pools/3-lc$^1/1-1-',1,
           [{file,
            "/home/circleci/project/src/wpool/mongoose_wpool.erl"},
          {line,129}]},
         {mongoose_wpool,start_configured_pools,1,[]}]}}},
   [{distributed_helper,rpc,
      [#{node => mongooseim@localhost},
       mongoose_wpool,start_configured_pools,
       [[#{scope => global,tag => default,type => elastic,
         opts =>
           #{strategy => best_worker,workers => 10,
           call_timeout => 5000},
         conn_opts => #{port => 9200,host => <<"localhost">>}}]]],
      [{file,
         "/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
       {line,143}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1799}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1396}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1240}]}]}...

Report log


pgsql_cets_latest / pgsql_cets / ffbb523
Status: 🟢 Passed
Reports root/ big
OK: 5475 / Failed: 0 / User-skipped: 213 / Auto-skipped: 0


pgsql_cets_legacy / pgsql_cets / ffbb523
Status: 🟢 Passed
Reports root/ big
OK: 16 / Failed: 0 / User-skipped: 0 / Auto-skipped: 0


mysql_cets_latest / mysql_cets / ffbb523
Status: 🟢 Passed
Reports root/ big
OK: 5473 / Failed: 0 / User-skipped: 215 / Auto-skipped: 0


pgsql_redis_latest / pgsql_redis / ffbb523
Status: 🟢 Passed
Reports root/ big
OK: 5555 / Failed: 0 / User-skipped: 378 / Auto-skipped: 0


pgsql_mnesia_latest / pgsql_mnesia / ffbb523
Status: 🟢 Passed
Reports root/ big
OK: 124 / Failed: 0 / User-skipped: 0 / Auto-skipped: 0


cockroachdb_cets_latest / cockroachdb_cets / ffbb523
Status: 🟢 Passed
Reports root/ big
OK: 6 / Failed: 0 / User-skipped: 2 / Auto-skipped: 0

@codecov

codecov Bot commented Jul 28, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 77.41935% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.92%. Comparing base (9d01be6) to head (ffbb523).

Files with missing lines Patch % Lines
src/muc_light/mod_muc_light_codec.erl 71.42% 4 Missing ⚠️
src/muc_light/mod_muc_light.erl 80.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4754      +/-   ##
==========================================
- Coverage   86.94%   86.92%   -0.03%     
==========================================
  Files         554      552       -2     
  Lines       33592    33369     -223     
==========================================
- Hits        29208    29006     -202     
+ Misses       4384     4363      -21     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mdbrnowski mdbrnowski changed the title Remove legacy codec from mod_muc_light MIM-2724 Remove legacy codec from mod_muc_light Jul 28, 2026
@mdbrnowski
mdbrnowski force-pushed the remove-muc-light-legacy-codec branch from 6623d73 to ba4b02a Compare July 30, 2026 09:12
@mdbrnowski
mdbrnowski force-pushed the remove-muc-light-legacy-codec branch from ba4b02a to 38317e8 Compare August 5, 2026 11:56
@mdbrnowski
mdbrnowski marked this pull request as ready for review August 5, 2026 13:50

@Premwoik Premwoik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR, I left two comments

Comment thread doc/migrations/6.8.0_6.x.x.md Outdated
Comment thread src/muc_light/mod_muc_light_codec.erl Outdated
@mdbrnowski
mdbrnowski requested a review from Premwoik August 6, 2026 14:26

@Premwoik Premwoik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdbrnowski
mdbrnowski merged commit 00696e3 into master Aug 10, 2026
3 of 4 checks passed
@mdbrnowski
mdbrnowski deleted the remove-muc-light-legacy-codec branch August 10, 2026 08:00
@chrzaszcz chrzaszcz added this to the 6.8.1 milestone Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants