Repository navigation
MIM-2724 Remove legacy codec from mod_muc_light - #4754
Conversation
|
CircleCI results for 094008a small_tests_legacy / small_tests / ffbb523 small_tests_latest / small_tests / ffbb523 small_tests_latest_arm64 / small_tests / ffbb523 ldap_mnesia_latest / ldap_mnesia / ffbb523 internal_mnesia_latest / internal_mnesia / ffbb523 dynamic_domains_pgsql_cets_latest / pgsql_cets / ffbb523 dynamic_domains_pgsql_cets_legacy / pgsql_cets / ffbb523 elasticsearch_and_cassandra_mnesia_latest / elasticsearch_and_cassandra_mnesia / ffbb523 mongoose_elasticsearch_SUITE:end_per_suite{error,
{{badrpc,
{'EXIT',
{#{what => event_already_registered,
event_name => wpool_global_queue_lengths,
labels => #{pool_type => elastic,pool_tag => default}},
[{mongoose_instrument,set_up,3,
[{file,
"/home/circleci/project/src/instrument/mongoose_instrument.erl"},
{line,114}]},
{lists,foreach_1,2,[{file,"lists.erl"},{line,2641}]},
{mongoose_wpool,start,5,
[{file,
"/home/circleci/project/src/wpool/mongoose_wpool.erl"},
{line,162}]},
{mongoose_wpool,'-start_configured_pools/3-lc$^1/1-1-',1,
[{file,
"/home/circleci/project/src/wpool/mongoose_wpool.erl"},
{line,129}]},
{mongoose_wpool,start_configured_pools,1,[]}]}}},
[{distributed_helper,rpc,
[#{node => mongooseim@localhost},
mongoose_wpool,start_configured_pools,
[[#{scope => global,tag => default,type => elastic,
opts =>
#{strategy => best_worker,workers => 10,
call_timeout => 5000},
conn_opts => #{port => 9200,host => <<"localhost">>}}]]],
[{file,
"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,143}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1799}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1396}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1240}]}]}...pgsql_cets_latest / pgsql_cets / ffbb523 pgsql_cets_legacy / pgsql_cets / ffbb523 mysql_cets_latest / mysql_cets / ffbb523 pgsql_redis_latest / pgsql_redis / ffbb523 pgsql_mnesia_latest / pgsql_mnesia / ffbb523 cockroachdb_cets_latest / cockroachdb_cets / ffbb523 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4754 +/- ##
==========================================
- Coverage 86.94% 86.92% -0.03%
==========================================
Files 554 552 -2
Lines 33592 33369 -223
==========================================
- Hits 29208 29006 -202
+ Misses 4384 4363 -21 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mod_muc_lightmod_muc_light
6623d73 to
ba4b02a
Compare
ba4b02a to
38317e8
Compare
Premwoik
left a comment
There was a problem hiding this comment.
Good PR, I left two comments
This PR removes the deprecated codec subsystem from
mod_muc_light, hard-coding the modern MUC Light codec. It deletes the legacy codec and the codec backend dispatcher, folds the modern codec into a singlemod_muc_light_codecmodule called directly, and drops the deprecatedlegacy_modeoption along with its tests and docs.