Repository navigation
Update exml 4.0.0 - #4465
Update exml 4.0.0#4465
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
NelsonVides
left a comment
NelsonVides
left a comment
There was a problem hiding this comment.
Super nice removal of the dynamically compiled modules for big tests also!
Bunch of comments, praises, and suggestions.
This comment was marked as resolved.
This comment was marked as resolved.
3fc852a to
987e54c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
NelsonVides
left a comment
NelsonVides
left a comment
There was a problem hiding this comment.
last two commits, very good 👌🏽
987e54c to
da7225e
Compare
|
elasticsearch_and_cassandra_27 / elasticsearch_and_cassandra_mnesia / da7225e small_tests_26 / small_tests / da7225e small_tests_27 / small_tests / da7225e small_tests_27_arm64 / small_tests / da7225e ldap_mnesia_26 / ldap_mnesia / da7225e ldap_mnesia_27 / ldap_mnesia / da7225e internal_mnesia_27 / internal_mnesia / da7225e dynamic_domains_mysql_redis_27 / mysql_redis / da7225e dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / da7225e dynamic_domains_pgsql_mnesia_27 / pgsql_mnesia / da7225e pgsql_cets_27 / pgsql_cets / da7225e dynamic_domains_mssql_mnesia_27 / odbc_mssql_mnesia / da7225e pgsql_mnesia_26 / pgsql_mnesia / da7225e mysql_redis_27 / mysql_redis / da7225e cockroachdb_cets_27 / cockroachdb_cets / da7225e pubsub_SUITE:dag+manage_subscriptions:retrieve_user_subscriptions_test{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"alice_retrieve_user_subscriptions_test_2935@localhost/res1">>,
escalus_tcp,<0.103081.0>,
[{event_manager,<0.103033.0>},
{server,<<"localhost">>},
{username,
<<"alicE_retrieve_user_subscriptions_test_2935">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.103033.0>},
{server,<<"localhost">>},
{username,
<<"alicE_retrieve_user_subscriptions_test_2935">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"alice_retrieve_user_subscriptions_test_2935">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,
<<"alicE_retrieve_user_subscriptions_test_2935">>},
{server,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"9f8a9eeeb8396293">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{pubsub_tools,receive_response,3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,434}]},
{pubsub_tools,receive_and_check_response,4,
[{file,"/h...pgsql_mnesia_27 / pgsql_mnesia / da7225e mssql_mnesia_27 / odbc_mssql_mnesia / da7225e small_tests_27 / small_tests / da7225e |
| Attrs = case QueryID =/= undefined andalso QueryID =/= <<>> of | ||
| true-> | ||
| #{<<"queryid">> => QueryID}; | ||
| false -> | ||
| #{} | ||
| end, |
There was a problem hiding this comment.
Indentation and space before the arrow in true->
| undefined -> []; | ||
| _ -> [{<<"from">>, jid:to_binary(FromJID)}] | ||
| undefined -> #{}; | ||
| _ -> #{<<"from">> =>jid:to_binary(FromJID)} |
There was a problem hiding this comment.
| _ -> #{<<"from">> =>jid:to_binary(FromJID)} | |
| _ -> #{<<"from">> => jid:to_binary(FromJID)} |
NelsonVides
left a comment
NelsonVides
left a comment
There was a problem hiding this comment.
There's like two places where spacing is not ideal but screw it, we should have had a linter for this, this work is already not just enormous but also amazing, thank you so so much!
This PR updates exml dependency