Repository navigation
OTP-20271 - #11543
Merged
Merged
OTP-20271#11543
Conversation
keep_alive_timeout would check the time between opening a connection,
or right after sending a response, until the next request's headers
are parsed.
Now the timeout is cancelled as soon as new data arrives, before the
parsing.
Allow atom `infinity` as a value for keep_alive_timeout to disable the
timeout entirely.
This option sets a max timeout for how long a body read will wait for there to be more data delivered before it is terminated. A similar limit can be set by using max_bytes_per_second, but that is much harder to tune and predict, so we add a new option that reflects how nginx handles such timeouts.
- Rename the max_body_read_timeout option to request_timeout
(default unchanged, 60 seconds), matching its documented purpose
of bounding idle time between message chunk reads.
- Rename HTTP_MAX_BODY_READ_TIMEOUT macro to HTTP_REQUEST_READ_TIMEOUT.
- Rename #state fields timeout/body_timeout to keepalive_timeout/
request_timeout in httpd_request_handler, and the corresponding
activate_body_timeout/reset_body_timeout functions to
activate_request_timeout/reset_request_timeout.
- Guard activate_keepalive_timeout/1 with timer = undefined so it
only arms a fresh timer, instead of unconditionally overwriting
a running one.
- Update httpd.erl -doc and -spec LimitOption references, and widen
keep_alive_timeout/request_timeout types to include infinity().
- Update httpd_basic_SUITE to use the renamed request_timeout option.
Contributor
CT Test Results 1 files 11 suites 3m 46s ⏱️ Results for commit 4735e80. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
Whaileee
force-pushed
the
whaileee/OTP-20271
branch
from
September 1, 2026 07:36
4735e80 to
3bdf3b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.