jdk26+ reset the defineClass ByteBuffer position to match OpenJDK - #22882
Merged
Conversation
keithc-ca
requested changes
Nov 4, 2025
| @@ -2466,6 +2466,12 @@ protected final Class<?> defineClass(String name, java.nio.ByteBuffer buffer, Pr | |||
|
|
|||
| byte[] bytes = new byte[size]; | |||
| buffer.get(bytes); | |||
| /*[IF JAVA_SPEC_VERSION >= 26] */ | |||
| // Match OpenJDK behavior, see https://bugs.openjdk.org/browse/JDK-8352583 | |||
Contributor
There was a problem hiding this comment.
Please finish the comment with a period.
Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
keithc-ca
approved these changes
Nov 4, 2025
pshipton
added a commit
to pshipton/openjdk-tests
that referenced
this pull request
Nov 5, 2025
Issue eclipse-openj9/openj9#22861 Fixed via eclipse-openj9/openj9#22882 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
llxia
pushed a commit
to adoptium/aqa-tests
that referenced
this pull request
Nov 5, 2025
Issue eclipse-openj9/openj9#22861 Fixed via eclipse-openj9/openj9#22882 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested via https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/4821
Issue #22861