📢 แจ้งเตือน: eclipse eej/glassfish/pull/

Ariho-Seth · 2025-08-04T12:27:58Z

In this PR, the Update tool is removed from the docs since it doesn't exist in Eclipse GlassFish anymore.

Signed-off-by: Atwijukire Ariho Seth <120330466+Ariho-Seth@users.noreply.github.com>

Ariho-Seth · 2025-08-04T12:38:22Z

Hello @OndroMih, please review this PR and see if there's anything to adjust

OndroMih · 2025-08-04T12:34:29Z

 For information about how to create IPS packages, see the
 http://wikis.oracle.com/display/IpsBestPractices/[IPS best practices
 document] (`http://wikis.oracle.com/display/IpsBestPractices/`).


This can be removed too.

OndroMih · 2025-08-04T12:36:08Z

 [--virtualservers virtual_servers]
 [--contextroot context_root]
 [--precompilejsp={false|true}]
-[--verify={false|true}]


This can stay, see comment below.

OndroMih · 2025-08-04T12:38:50Z

 [--force={false|true}]
 [--virtualservers virtual_servers]
 [--contextroot context_root]
-[--verify={false|true}]


Can stay, as per my other comment.

OndroMih · 2025-08-04T13:37:38Z

           during deployment. Instead, JSPs are compiled during runtime.
           Default is false.

-       --verify


Can stay, as per my other comment - just remove the reference to the Update Tool

OndroMih · 2025-08-04T13:38:06Z

           [--generatermistubs={false|true}]
           [--contextroot context_root]
           [--precompilejsp={true|false}]
-           [--verify={false|true}]


Can stay, as per my other comment

OndroMih · 2025-08-04T13:38:18Z

           during deployment. Instead, JSPs are compiled during runtime.
           Default is false.

-       --verify


Can stay, as per my other comment - just remove the reference to the Update Tool

Sure thing, I've added the suggested changes, Please peruse through and see .

Signed-off-by: Atwijukire Ariho Seth <120330466+Ariho-Seth@users.noreply.github.com>

OndroMih · 2025-08-04T14:00:51Z

+  `--verify`::
+    If set to true and the required verifier packages are installed from
+    the Update Tool, the syntax and semantics of the deployment descriptor
+    is verified. Default is `false`.


Please revert the indentation (remove the additional spaces in the beginnings of lines)

OndroMih · 2025-08-04T14:01:10Z

+  `--verify`::
+    If set to true and the required verifier packages are installed from
+    the Update Tool, the syntax and semantics of the deployment descriptor
+    is verified. Default is `false`.


Please revert the indentation (remove the additional spaces in the beginnings of lines)

OndroMih · 2025-08-04T14:01:27Z

+  `--verify`::
+    If set to true and the required verifier packages are installed from
+    the Update Tool, the syntax and semantics of the deployment descriptor
+    is verified. Default is `false`.


Please revert the indentation (remove the additional spaces in the beginnings of lines)

OndroMih

All looks good in the final PDFs, just remove the unnecessry indentation to keep things aligned in the source.

Signed-off-by: Atwijukire Ariho Seth <120330466+Ariho-Seth@users.noreply.github.com>

Ariho-Seth · 2025-08-04T14:12:00Z

All looks good in the final PDFs, just remove the unnecessry indentation to keep things aligned in the source.

Sorry about that negligence :), but I hope now all is good.

OndroMih · 2025-08-04T14:19:50Z

I'm a bit pedantic :)

Now I noticed that you put back mentions of Update Tool in the documentation of the --verify option:

 If set to true and the required verifier packages are installed from
  the Update Tool, the syntax and semantics of the deployment descriptor
  is verified. Default is `false`.

Can you remove Update Tool everywhere, so that it reads something like:

 If set to true and the required verifier packages are installed,
  the syntax and semantics of the deployment descriptor
  is verified. Default is `false`.

Signed-off-by: Atwijukire Ariho Seth <120330466+Ariho-Seth@users.noreply.github.com>

Ariho-Seth · 2025-08-04T14:34:18Z

I'm a bit pedantic :)

Now I noticed that you put back mentions of Update Tool in the documentation of the --verify option:
 If set to true and the required verifier packages are installed from
  the Update Tool, the syntax and semantics of the deployment descriptor
  is verified. Default is `false`.
Can you remove Update Tool everywhere, so that it reads something like:
 If set to true and the required verifier packages are installed,
  the syntax and semantics of the deployment descriptor
  is verified. Default is `false`.

"Pediatric!", I think it's fine to choose quality,
I've fixed the --verify option too. I'm ready to make any more adjustments for quality

OndroMih

I think you missed to remove mention of Update Tool in deploy.1, deploydir.1 and redeploy.1 files.

There are still some references to the Update Tool in the upgrade guide, but I think we can leave them there. The upgrade guide should be completely updated, I raised an issue for that: #25656

OndroMih · 2025-08-04T15:28:57Z

@@ -95,7 +95,6 @@ OPTIONS
           If set to true and the required verifier packages are installed
           from the Update Tool, the syntax and semantics of the deployment


One more reference to Update Tool to remove :)

OndroMih · 2025-08-04T15:44:33Z

I would also remove mentions of the Update Tool in the FAQ. The documentation is for the current GlassFish version, not for legacy versions. And the Update Tool is not available anymore. Not even for old GlassFish versions, because the update service is not available anymore. The Update Tool may be there it it wouldn't be able to download and install modules.

We still have documentation for GlassFish 5, which is available here: https://glassfish.org/docs/#5.1.0. This documentation contains info about the Update Tool and we're not going to remove it from there.

Signed-off-by: Atwijukire Ariho Seth <120330466+Ariho-Seth@users.noreply.github.com>

Ariho-Seth · 2025-08-04T16:15:36Z

I've also removed its references from the FAQs too

OndroMih · 2025-08-04T16:39:47Z

Perfect. One last thing - can you remove references to Update Tool also in deploy.1 and redeploy.1 files?

Signed-off-by: Atwijukire Ariho Seth <120330466+Ariho-Seth@users.noreply.github.com>

Ariho-Seth · 2025-08-07T11:18:17Z

Perfect. One last thing - can you remove references to Update Tool also in deploy.1 and redeploy.1 files?

Hello @OndroMih, are there changes we need to add in here?

OndroMih · 2025-08-07T12:52:27Z

All good now, thanks @Ariho-Seth !

Ariho-Seth · 2025-08-07T12:59:14Z

Welcome @OndroMih, Thanks for your unwavering efforts to improve me too.

Removed references to the Update Tool in docs

Removed references to the Update Tool in docs

7e8208d

Signed-off-by: Atwijukire Ariho Seth <120330466+Ariho-Seth@users.noreply.github.com>

Ariho-Seth marked this pull request as ready for review August 4, 2025 12:36

Ariho-Seth mentioned this pull request Aug 4, 2025

Documentation: Remove references to Update Tool in the documentation guides #24304

Closed

OndroMih requested changes Aug 4, 2025

View reviewed changes

Suggested changes added

6f14a81

Signed-off-by: Atwijukire Ariho Seth <120330466+Ariho-Seth@users.noreply.github.com>

OndroMih reviewed Aug 4, 2025

View reviewed changes

Corrected indetation

cd19f0b

Signed-off-by: Atwijukire Ariho Seth <120330466+Ariho-Seth@users.noreply.github.com>

Removed the Update tool from the --verify option

4aeb6ba

Signed-off-by: Atwijukire Ariho Seth <120330466+Ariho-Seth@users.noreply.github.com>

OndroMih reviewed Aug 4, 2025

View reviewed changes

Removed references to the Update Tool form the FAQs

9a5569c

Signed-off-by: Atwijukire Ariho Seth <120330466+Ariho-Seth@users.noreply.github.com>

Suggested changes added

89f5af9

Signed-off-by: Atwijukire Ariho Seth <120330466+Ariho-Seth@users.noreply.github.com>

Ariho-Seth requested a review from OndroMih August 7, 2025 11:18

OndroMih approved these changes Aug 7, 2025

View reviewed changes

OndroMih merged commit ab63848 into eclipse-ee4j:master Aug 7, 2025
2 checks passed

bvfalcon pushed a commit to bvfalcon/eclipse-glassfish that referenced this pull request Apr 25, 2026

Merge pull request eclipse-ee4j#25655 from Ariho-Seth/master

9f079e7

Removed references to the Update Tool in docs

		@@ -95,7 +95,6 @@ OPTIONS
		If set to true and the required verifier packages are installed
		from the Update Tool, the syntax and semantics of the deployment

Uh oh!

Conversation

Ariho-Seth commented Aug 4, 2025

Uh oh!

Ariho-Seth commented Aug 4, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OndroMih left a comment

Choose a reason for hiding this comment

Uh oh!

Ariho-Seth commented Aug 4, 2025

Uh oh!

OndroMih commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ariho-Seth commented Aug 4, 2025

Uh oh!

OndroMih left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OndroMih commented Aug 4, 2025

Uh oh!

Ariho-Seth commented Aug 4, 2025

Uh oh!

OndroMih commented Aug 4, 2025

Uh oh!

Ariho-Seth commented Aug 7, 2025

Uh oh!

Uh oh!

OndroMih commented Aug 7, 2025

Uh oh!

Ariho-Seth commented Aug 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

OndroMih commented Aug 4, 2025 •

edited

Loading