Skip to content

Upload PDFs built in workflow - #25653

Merged
pzygielo merged 1 commit into
eclipse-ee4j:masterfrom
pzygielo:pdfs
Aug 3, 2025
Merged

Upload PDFs built in workflow#25653
pzygielo merged 1 commit into
eclipse-ee4j:masterfrom
pzygielo:pdfs

Conversation

@pzygielo

@pzygielo pzygielo commented Aug 3, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@pzygielo
pzygielo marked this pull request as ready for review August 3, 2025 19:16
@pzygielo
pzygielo merged commit 4aeee92 into eclipse-ee4j:master Aug 3, 2025
2 checks passed
@pzygielo
pzygielo deleted the pdfs branch August 3, 2025 20:26
@dmatej dmatej added this to the 7.1.0 milestone Aug 3, 2025
@OndroMih

OndroMih commented Aug 4, 2025

Copy link
Copy Markdown
Contributor

If only the PDFs could be updloaded individually, not just as a ZIP file with all of them. It's a known issue that the actions/upload-artifact action doesn't support that, a pity. But better than nothing :)

It's possible to download the PDFs like this:

  • click details on the workflow for building PDFs (it will be easier to find the right workflow with Display GitHub workflow names in pull requests #25654)
  • click Summary in the left sidebar
  • scroll down to Artifacts and download the docs-pdfs zip file, unpack and open a PDF locally

@pzygielo

pzygielo commented Aug 4, 2025

Copy link
Copy Markdown
Contributor Author

If only the PDFs could be updloaded individually, not just as a ZIP file with all of them. It's a known issue that the actions/upload-artifact action doesn't support that, a pity.

Yeah, even if we'd enumerate all of them for the separate artifacts - the action would zip them, and we'd end up with several archives to work with. 😞

Let's wait for:

@pzygielo

Copy link
Copy Markdown
Contributor Author

If only the PDFs could be updloaded individually,

ðŸ˜Ū https://github.com/actions/upload-artifact/releases/tag/v7.0.0

Direct Uploads

Adds support for uploading single files directly (unzipped). Callers can set the new archive parameter to false to skip zipping the file during upload. Right now, we only support single files. The action will fail if the glob passed resolves to multiple files. The name parameter is also ignored with this setting. Instead, the name of the artifact will be the name of the uploaded file.

@OndroMih

Copy link
Copy Markdown
Contributor

@pzygielo , we would need to copy the action for each PDF. Is it worth the effort?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants