Updated the installation guide by replacing obsolete info with GF7 info - #25641
Conversation
Signed-off-by: Atwijukire Ariho Seth <120330466+Ariho-Seth@users.noreply.github.com>
| |Jakarta Security 3.0 supporting OpenID Connect |X |X | ||
|
|
||
| |Java API for JSON Processing 1.1 |X |X | ||
| |Jakarta JSON Processing 2.1.3 |X |X |
There was a problem hiding this comment.
I would remove the patch version, which can easily change with some fix. THe major and minor version of components is important.
| |Jakarta JSON Processing 2.1.3 |X |X | |
| |Jakarta JSON Processing 2.1 |X |X |
| |JDBC 4.0 |X |X | ||
|
|
||
| |Apache Derby 10.13.1.1 |X |X | ||
| |Apache Derby 10.15.2.0 |X |X |
There was a problem hiding this comment.
Derby is not a Jakarta EE API, we are not bound to any version - we can upgrade it to any version, it's not worth keeping the version number in this guide. Unless we generate the version from pom.xml, which would be nice, but we don't do it now. It's better to remove the version rather than keep an outdated version.
| |Apache Derby 10.15.2.0 |X |X | |
| |Apache Derby|X |X |
There was a problem hiding this comment.
Actually it could be worth to have the concrete version and also to link to its documentation from our documentation, but that is probably work for another task. However ... when you mentioned filtering, we have these properties in POMs.
There was a problem hiding this comment.
I agree, this would be for another task. And it would be really useful to publish the versions of components this way, but it has to be automated. We're not capable of keeping the versions up to date manually.
There was a problem hiding this comment.
Actually, the versions are already defined, so we could directly reference them in the docs, like {derby.version}. The problem is that asciidoc doesn't support period in the reference, so we need to redeclare them as variables without periods, fore example: ${derby.version}, and then refer to them as {derbyVersion} in adoc files. That works, I just tried.
There was a problem hiding this comment.
I created a separate issue to reference real versions of components: #25642.
@Ariho-Seth, if you want, you can resolve that issue in this same PR, it should be pretty easy as I described in that issue.
It would then be OK also to use patch numbers for Jakarta EE APIs, for example 3.1.1 instead of 3.1, because it would be automatically kept up to date.
There was a problem hiding this comment.
Sure thing, let me work on that
|
|
||
| |Rapid Redeployment (Maintain session state on application redeploy) |X |X | ||
|
|
||
| |OMG CORBA APIs 3.0 |X |X |
There was a problem hiding this comment.
I would remove the version here for the same reasons as for Derby DB.
| |OMG CORBA APIs 3.0 |X |X | |
| |OMG CORBA APIs |X |X |
| |Bean Validation 2.0 |X |X | ||
| |Bean Validation 3.0 |X |X | ||
|
|
||
| |JAX-RS 2.1 (Jersey) |X |X |
There was a problem hiding this comment.
| |JAX-RS 2.1 (Jersey) |X |X | |
| |RESTful Web Services 3.1 (Jersey) |X |X |
|
|
||
| |JAXR 1.0 |X |- | ||
|
|
||
| |CORBA 3.0.0 |X a|* |
There was a problem hiding this comment.
I would remove the version as this is not a Jakarta EE spec
| |CORBA 3.0.0 |X a|* | |
| |CORBA |X a|* |
Signed-off-by: Atwijukire Ariho Seth <120330466+Ariho-Seth@users.noreply.github.com>
|
Thanks @OndroMih, for your review, I've worked on the suggested changes, please let me know of any adjustments in case. |
Signed-off-by: Atwijukire Ariho Seth <120330466+Ariho-Seth@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
âĶation guide" This reverts commit a668980.
Changes introduced after approval to be reverted.
Signed-off-by: Atwijukire Ariho Seth <120330466+Ariho-Seth@users.noreply.github.com>
Signed-off-by: Atwijukire Ariho Seth <120330466+Ariho-Seth@users.noreply.github.com>
Signed-off-by: Atwijukire Ariho Seth <120330466+Ariho-Seth@users.noreply.github.com>
Signed-off-by: Atwijukire Ariho Seth <120330466+Ariho-Seth@users.noreply.github.com>
pzygielo
left a comment
There was a problem hiding this comment.
ð
but I've checked only for property references.
Updated the installation guide by replacing obsolete info with GF7 info and automatically generate component version numbers
Updated the https://github.com/eclipse-ee4j/glassfish/blob/master/docs/installation-guide/src/main/asciidoc/installing.adoc by:
MOZILLA PUBLIC LICENSE Version 2.0