Skip to content

Updated the installation guide by replacing obsolete info with GF7 info - #25641

Merged
OndroMih merged 11 commits into
eclipse-ee4j:masterfrom
Ariho-Seth:master
Aug 1, 2025
Merged

Updated the installation guide by replacing obsolete info with GF7 info#25641
OndroMih merged 11 commits into
eclipse-ee4j:masterfrom
Ariho-Seth:master

Conversation

@Ariho-Seth

@Ariho-Seth Ariho-Seth commented Jul 30, 2025

Copy link
Copy Markdown
Contributor

Updated the https://github.com/eclipse-ee4j/glassfish/blob/master/docs/installation-guide/src/main/asciidoc/installing.adoc by:

  • Updating the Javassist Library License Notice with the MOZILLA PUBLIC LICENSE Version 2.0
  • Updated the Eclipse GlassFish Full Profile and Web Profile Features with the current versions
  • Removed Solaris OS from the installation procedures.

Signed-off-by: Atwijukire Ariho Seth <120330466+Ariho-Seth@users.noreply.github.com>
Comment thread docs/installation-guide/src/main/asciidoc/installing.adoc
|Jakarta Security 3.0 supporting OpenID Connect |X |X

|Java API for JSON Processing 1.1 |X |X
|Jakarta JSON Processing 2.1.3 |X |X

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the patch version, which can easily change with some fix. THe major and minor version of components is important.

Suggested change
|Jakarta JSON Processing 2.1.3 |X |X
|Jakarta JSON Processing 2.1 |X |X

|JDBC 4.0 |X |X

|Apache Derby 10.13.1.1 |X |X
|Apache Derby 10.15.2.0 |X |X

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Derby is not a Jakarta EE API, we are not bound to any version - we can upgrade it to any version, it's not worth keeping the version number in this guide. Unless we generate the version from pom.xml, which would be nice, but we don't do it now. It's better to remove the version rather than keep an outdated version.

Suggested change
|Apache Derby 10.15.2.0 |X |X
|Apache Derby|X |X

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it could be worth to have the concrete version and also to link to its documentation from our documentation, but that is probably work for another task. However ... when you mentioned filtering, we have these properties in POMs.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, this would be for another task. And it would be really useful to publish the versions of components this way, but it has to be automated. We're not capable of keeping the versions up to date manually.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the versions are already defined, so we could directly reference them in the docs, like {derby.version}. The problem is that asciidoc doesn't support period in the reference, so we need to redeclare them as variables without periods, fore example: ${derby.version}, and then refer to them as {derbyVersion} in adoc files. That works, I just tried.

@OndroMih OndroMih Jul 30, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a separate issue to reference real versions of components: #25642.

@Ariho-Seth, if you want, you can resolve that issue in this same PR, it should be pretty easy as I described in that issue.

It would then be OK also to use patch numbers for Jakarta EE APIs, for example 3.1.1 instead of 3.1, because it would be automatically kept up to date.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing, let me work on that


|Rapid Redeployment (Maintain session state on application redeploy) |X |X

|OMG CORBA APIs 3.0 |X |X

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the version here for the same reasons as for Derby DB.

Suggested change
|OMG CORBA APIs 3.0 |X |X
|OMG CORBA APIs |X |X

|Bean Validation 2.0 |X |X
|Bean Validation 3.0 |X |X

|JAX-RS 2.1 (Jersey) |X |X

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
|JAX-RS 2.1 (Jersey) |X |X
|RESTful Web Services 3.1 (Jersey) |X |X


|JAXR 1.0 |X |-

|CORBA 3.0.0 |X a|*

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the version as this is not a Jakarta EE spec

Suggested change
|CORBA 3.0.0 |X a|*
|CORBA |X a|*

Signed-off-by: Atwijukire Ariho Seth <120330466+Ariho-Seth@users.noreply.github.com>
@Ariho-Seth

Copy link
Copy Markdown
Contributor Author

Thanks @OndroMih, for your review, I've worked on the suggested changes, please let me know of any adjustments in case.

OndroMih
OndroMih previously approved these changes Jul 30, 2025
Signed-off-by: Atwijukire Ariho Seth <120330466+Ariho-Seth@users.noreply.github.com>
Comment thread nucleus/parent/pom.xml Outdated
@Ariho-Seth

Ariho-Seth commented Jul 30, 2025

Copy link
Copy Markdown
Contributor Author

Hello @OndroMih, please have a look at this commit for the solution to the discussion above.
It also fixes this issue #25642

Please feel free to suggest any other adjustments if necessary

Comment thread docs/installation-guide/src/main/asciidoc/installing.adoc Outdated
@pzygielo

This comment was marked as resolved.

@pzygielo
pzygielo dismissed OndroMih’s stale review July 30, 2025 17:22

Changes introduced after approval to be reverted.

Signed-off-by: Atwijukire Ariho Seth <120330466+Ariho-Seth@users.noreply.github.com>
@Ariho-Seth

Copy link
Copy Markdown
Contributor Author

Hello @pzygielo, @OndroMih, hope these changes look clean now?

Comment thread docs/installation-guide/src/main/asciidoc/installing.adoc Outdated
Comment thread docs/installation-guide/src/main/asciidoc/installing.adoc Outdated
Comment thread docs/installation-guide/src/main/asciidoc/installing.adoc Outdated
Signed-off-by: Atwijukire Ariho Seth <120330466+Ariho-Seth@users.noreply.github.com>
Signed-off-by: Atwijukire Ariho Seth <120330466+Ariho-Seth@users.noreply.github.com>
Comment thread appserver/pom.xml Outdated
Comment thread appserver/pom.xml Outdated
Signed-off-by: Atwijukire Ariho Seth <120330466+Ariho-Seth@users.noreply.github.com>

@pzygielo pzygielo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

but I've checked only for property references.

Comment thread docs/installation-guide/src/main/asciidoc/installing.adoc Outdated
Comment thread docs/installation-guide/src/main/asciidoc/installing.adoc Outdated
Comment thread docs/installation-guide/src/main/asciidoc/installing.adoc Outdated
Comment thread docs/installation-guide/src/main/asciidoc/installing.adoc Outdated
Comment thread docs/installation-guide/src/main/asciidoc/installing.adoc Outdated
Comment thread docs/installation-guide/src/main/asciidoc/installing.adoc Outdated
Comment thread docs/installation-guide/src/main/asciidoc/installing.adoc Outdated
Comment thread docs/installation-guide/src/main/asciidoc/installing.adoc
Comment thread docs/installation-guide/src/main/asciidoc/installing.adoc Outdated
Comment thread docs/installation-guide/src/main/asciidoc/installing.adoc Outdated
Comment thread docs/installation-guide/src/main/asciidoc/installing.adoc Outdated
Comment thread docs/installation-guide/src/main/asciidoc/installing.adoc Outdated
@OndroMih
OndroMih merged commit df02570 into eclipse-ee4j:master Aug 1, 2025
2 checks passed
bvfalcon pushed a commit to bvfalcon/eclipse-glassfish that referenced this pull request Apr 25, 2026
Updated the installation guide by replacing obsolete info with GF7 info and automatically generate component version numbers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automatically generate versions of components in the installation guide Update the installation guide which is still based on GF5

4 participants