Streamline and somewhat update MP TCKs - #25403
Merged
Merged
Conversation
dmatej
reviewed
Mar 10, 2025
| <groupId>org.glassfish.main.tests.tck</groupId> | ||
| <artifactId>tck</artifactId> | ||
| <version>8.0.0-SNAPSHOT</version> | ||
| <groupId>org.eclipse.ee4j</groupId> |
Contributor
Author
There was a problem hiding this comment.
I was trying to run the TCK against arbitirary GlassFish versions. With the project parent it insisted upon having basically all of GlassFisg build in the version that the project happened to be. This is unnecessary when testing with such specific version.
OndroMih
reviewed
Mar 10, 2025
| @@ -0,0 +1,91 @@ | |||
| <!DOCTYPE suite SYSTEM "http://testng.org/testng-1.0.dtd" > | |||
Contributor
There was a problem hiding this comment.
Is this file needed? Isn't it retrieved from the org.eclipse.microprofile.jwt:microprofile-jwt-auth-tck dependency already?
Contributor
Author
There was a problem hiding this comment.
It's to be consistent with the other two mp tcks; they do the same thing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.