Skip to content

feat(settings): echo location name in location search - #3040

Merged
purian23 merged 4 commits into
duxlabs-dev:masterfrom
Curious-r:feat/location-search-echo
Aug 13, 2026
Merged

purian23 merged 4 commits into
duxlabs-dev:masterfrom
Curious-r:feat/location-search-echo

Conversation

@Curious-r

@Curious-r Curious-r commented Aug 11, 2026 •

Copy link
Copy Markdown
Contributor

Description

Adds city-name echo to the location search field in all three places and fixes a couple of related issues found while testing:

  • Theme & Gamma auto-location now persist the selected city name in a new nightModeLocationName session property and prefill the search field with it; manually editing coordinates clears the name again.
  • Weather search gets the same echo via the existing weatherLocation, and no longer silently loses it when the settings tab initializes or fills coordinates from a search result.
  • Manual coordinate fields in Theme & Gamma now use the same full-width layout as the weather page (aligned insets, matching title weight).
  • DankLocationSearch (via the submodule bump) now shows a selected-state check icon after picking a result instead of a misleading error icon, and supports the currentLocation echo.

Have tested on hardware with https://github.com/Curious-r/nix-config/tree/test/dms-location-search-echo

  • Search → select a city: lat/lon auto-fill and the day/night switch reacts in both Theme & Colors and Gamma Control.
  • Echo: after selection, reopening settings or switching tabs prefills the search field with the city name; manually editing lat/lon clears it back to the placeholder.
  • Cross-tab: coordinates and the echoed name stay in sync in both directions (Gamma ⇄ Theme), including after manual edits.
  • Icon: focusing the search field after a selection shows the check icon rather than the red error icon.
  • Layout: the unified manual-coordinates form renders correctly in both tabs.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that changes existing behavior)
  • Refactor / internal cleanup
  • Documentation
  • Other

Related issues

Screenshots / video

1786419135292595840 1786419141485273120

Checklist

  • My code follows the conventions in CONTRIBUTING.md
  • I have tested my changes locally
  • New user-facing strings are wrapped in I18n.tr() with translator context, reusing existing terms where possible
  • Go changes: ran make fmt, added/updated tests, make test passes, and go mod tidy is clean
  • QML changes: ran make lint-qml with no new warnings
  • I have opened a corresponding pull request in dlx-docs to document any new behaviors: https://github.com/AvengeMedia/DankLinux-Docs

@Curious-r

Copy link
Copy Markdown
Contributor Author

This is the follow-up PR we discussed last time. I’d appreciate it if you could take a look when you have a chance. Thank you!
@purian23

@Curious-r
Curious-r force-pushed the feat/location-search-echo branch from 95c762a to 2aae2c3 Compare August 13, 2026 05:27
@Curious-r
Curious-r force-pushed the feat/location-search-echo branch from 2aae2c3 to dd5ce47 Compare August 13, 2026 19:44
@Curious-r
Curious-r marked this pull request as ready for review August 13, 2026 19:47
@purian23
purian23 merged commit 70d0dd8 into duxlabs-dev:master Aug 13, 2026
2 checks passed
@Curious-r
Curious-r deleted the feat/location-search-echo branch August 13, 2026 22:03
marcusramberg pushed a commit to marcusramberg/DankMaterialShell that referenced this pull request Sep 2, 2026
* feat(settings): persist named location for theme & gamma auto modes

* chore: bump dank-qml-common for location search support

* fix(settings): keep weather location name when search fills coordinates

* style(settings): unify manual coordinates layout with weather
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants