Repository navigation
feat(settings): echo location name in location search - #3040
Merged
purian23 merged 4 commits intoAug 13, 2026
Merged
Conversation
Curious-r
marked this pull request as draft
August 11, 2026 03:34
2 tasks done
Contributor
Author
|
This is the follow-up PR we discussed last time. I’d appreciate it if you could take a look when you have a chance. Thank you! |
Curious-r
force-pushed
the
feat/location-search-echo
branch
from
August 13, 2026 05:27
95c762a to
2aae2c3
Compare
Curious-r
force-pushed
the
feat/location-search-echo
branch
from
August 13, 2026 19:44
2aae2c3 to
dd5ce47
Compare
Curious-r
marked this pull request as ready for review
August 13, 2026 19:47
marcusramberg
pushed a commit
to marcusramberg/DankMaterialShell
that referenced
this pull request
Sep 2, 2026
* feat(settings): persist named location for theme & gamma auto modes * chore: bump dank-qml-common for location search support * fix(settings): keep weather location name when search fills coordinates * style(settings): unify manual coordinates layout with weather
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds city-name echo to the location search field in all three places and fixes a couple of related issues found while testing:
nightModeLocationNamesession property and prefill the search field with it; manually editing coordinates clears the name again.weatherLocation, and no longer silently loses it when the settings tab initializes or fills coordinates from a search result.DankLocationSearch(via the submodule bump) now shows a selected-state check icon after picking a result instead of a misleading error icon, and supports thecurrentLocationecho.Have tested on hardware with https://github.com/Curious-r/nix-config/tree/test/dms-location-search-echo
Type of change
Related issues
Screenshots / video
Checklist
I18n.tr()with translator context, reusing existing terms where possiblemake fmt, added/updated tests,make testpasses, andgo mod tidyis cleanmake lint-qmlwith no new warnings