Repository navigation
feat(niri): close overview on window focus - #3030
Merged
bbedward merged 2 commits intoAug 17, 2026
Merged
Conversation
Collaborator
|
Hi there, from the writeup it's a bit of a change. Can you provide a video walkthrough of the feature you're looking to implement. Thanks! |
Contributor
Author
2026-08-10_02-09-23_03-25.mp4 |
Contributor
Author
|
I definitely need more time to make this PR clearer. |
korbash
force-pushed
the
feat/niri-overview-window-focus
branch
from
August 10, 2026 16:04
c96f6fe to
8f34cc6
Compare
Contributor
Author
|
I rewrote the PR to centralize the behavior instead of adding Niri overview checks at individual UI call sites. The overview close logic now lives in the lower-level paths:
The old launcher-only setting was replaced with |
korbash
force-pushed
the
feat/niri-overview-window-focus
branch
from
August 13, 2026 17:59
8f34cc6 to
8926301
Compare
bbedward
requested changes
Aug 17, 2026
| "label": "Niri Integration", | ||
| "tabIndex": 9, | ||
| "category": "Launcher", | ||
| "section": "closeNiriOverviewOnWindowFocus", |
Member
There was a problem hiding this comment.
Pre-commit will reject this because its hand-edited, it is generated by the python scriptin the same folder
bbedward
force-pushed
the
feat/niri-overview-window-focus
branch
from
August 17, 2026 17:23
8926301 to
0197238
Compare
by-architect
pushed a commit
to by-architect/Phoenix
that referenced
this pull request
Aug 19, 2026
* feat(niri): close overview on window focus * feat(niri): close overview on window focus --------- Co-authored-by: bbedward <bbedward@gmail.com>
marcusramberg
pushed a commit
to marcusramberg/DankMaterialShell
that referenced
this pull request
Sep 2, 2026
* feat(niri): close overview on window focus * feat(niri): close overview on window focus --------- Co-authored-by: bbedward <bbedward@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a single Niri-only Close Overview on Window Focus option under Personalization → Niri → Overview.
When enabled, DMS closes Niri's overview when an action launches or focuses a window from:
This replaces the launcher-specific Close Overview on Launch option. Existing
spotlightCloseNiriOverviewvalues are migrated to the new shared setting, preserving the user's current preference.The option is enabled by default. Disabling it keeps the overview open. Non-Niri sessions are unaffected and never attempt to toggle Niri's overview.
Possible follow-up
The remaining Enable Overview Overlay option still lives under Launcher → Niri Integration. It may make sense to move it to Personalization → Niri → Overview in a separate change, keeping all Niri overview behavior in one place.
Type of change
Related issues
Closes #2379
Screenshots / video
Checklist
I18n.tr()with translator context, reusing existing terms where possiblemake lint-qmlwith no new warnings