Skip to content

feat: lockscreen screen filter - #2740

Merged
bbedward merged 1 commit into
duxlabs-dev:masterfrom
scottmckendry:lockscreen-screen-filter
Jul 4, 2026
Merged

bbedward merged 1 commit into
duxlabs-dev:masterfrom
scottmckendry:lockscreen-screen-filter

Conversation

@scottmckendry

@scottmckendry scottmckendry commented Jul 4, 2026 •

Copy link
Copy Markdown
Contributor

Description

this makes use of the existing getFilteredScreens function and settings node to allow users to specify which displays the lockscreen should appear on. prior to this change, it was "all" or just one. This PR also handles the migrating of the old setting (if required).

New setting removes the old drop-down, and follows the same style/behaviour as the DankBar display settings.

Before:

image

After:

1783129753400971680

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that changes existing behavior)
  • Refactor / internal cleanup
  • Documentation
  • Other

Related issues

Screenshots / video

Checklist

  • My code follows the conventions in CONTRIBUTING.md
  • I have tested my changes locally
  • New user-facing strings are wrapped in I18n.tr() with translator context, reusing existing terms where possible
  • Go changes: ran make fmt, added/updated tests, make test passes, and go mod tidy is clean
  • QML changes: ran make lint-qml with no new warnings
  • I have opened a corresponding pull request in dlx-docs to document any new behaviors: https://github.com/AvengeMedia/DankLinux-Docs

@scottmckendry
scottmckendry force-pushed the lockscreen-screen-filter branch 2 times, most recently from 7417d99 to 7b089c5 Compare July 4, 2026 01:50
@scottmckendry scottmckendry changed the title feat: lockscreen can be filtered like other components feat: lockscreen screen filter Jul 4, 2026
this makes use of the existing getFilteredScreens function to allow
users to specify which displays the lockscreen should appear on. prior
to this change, it was "all" or just one.
@scottmckendry
scottmckendry force-pushed the lockscreen-screen-filter branch from 7b089c5 to 7643cdc Compare July 4, 2026 01:58
@bbedward
bbedward merged commit 7b1c542 into duxlabs-dev:master Jul 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants