Skip to content

chore: update vector-bench README - #6117

Merged
romange merged 1 commit into
mainfrom
Pr6
Nov 25, 2025
Merged

romange merged 1 commit into
mainfrom
Pr6

Conversation

@romange

@romange romange commented Nov 25, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

@romange
romange requested a review from dranikpg November 25, 2025 17:32

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Comment augment review to trigger a new review at any time.

| `-p` | 6379 | **Port** of the server. |
| `-h` | localhost | **Host** of the server. |

Run with `-h` (help) to see these defaults in the tool itself.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using -h here to indicate help appears inconsistent: the tool defines -h as the host flag, so -h will not show help. The Go flag package exposes help via -help/--help, so this line could mislead users.

🤖 Was this useful? React with 👍 or 👎

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This boy got a point, it's -help

@romange
romange enabled auto-merge (squash) November 25, 2025 18:23
@romange
romange merged commit 7605669 into main Nov 25, 2025
10 checks passed
@romange
romange deleted the Pr6 branch November 25, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants