Skip to content

[dotnet] Add numerous item templates. Fixes #15836. - #16287

Merged
rolfbjarne merged 4 commits into
dotnet:mainfrom
rolfbjarne:dotnet-item-templates
Oct 10, 2022
Merged

[dotnet] Add numerous item templates. Fixes #15836.#16287
rolfbjarne merged 4 commits into
dotnet:mainfrom
rolfbjarne:dotnet-item-templates

Conversation

@rolfbjarne

Copy link
Copy Markdown
Member

Add the following item templates for all platforms:

  • Controller (View Controller with UI written in code)
  • View
  • View Controller (View Controller with UI written in XIB)
  • Storyboard

Item templates won't show up in VSMac until this is released:
https://github.com/xamarin/vsmac/pull/9133.

Fixes #15836.

Also update the template tests accordingly.

This PR might be easier to review commit-by-commit due to the large number of generated localization files.

Add the following item templates for all platforms:

* Controller (View Controller with UI written in code)
* View
* View Controller (View Controller with UI written in XIB)
* Storyboard

Item templates won't show up in VSMac until this is released: xamarin/vsmac#9133.

Fixes dotnet#15836.
@rolfbjarne rolfbjarne added the not-notes-worthy Ignore for release notes label Oct 7, 2022
@github-actions

github-actions Bot commented Oct 7, 2022

Copy link
Copy Markdown
Contributor

⚠ïļ Your code has been reformatted. ⚠ïļ

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

@dalexsoto

Copy link
Copy Markdown
Member

Go auto format 😀

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: c16ef7044cd42397b4b68d3032375f2706380189 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1107.Monterey'
Hash: c16ef7044cd42397b4b68d3032375f2706380189 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

ðŸ’ŧ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed ðŸ’ŧ

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: c16ef7044cd42397b4b68d3032375f2706380189 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

ðŸ”Ĩ [CI Build] Test results ðŸ”Ĩ

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 1 tests failed, 222 tests passed.

Failures

❌ linker tests

1 tests failed, 64 tests passed.
Details
  • trimmode link/tvOS - simulator/Debug [dotnet]: Failed

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

@rolfbjarne

Copy link
Copy Markdown
Member Author

Test failure is unrelated (https://github.com/xamarin/maccore/issues/1083).

@rolfbjarne
rolfbjarne merged commit acf4edb into dotnet:main Oct 10, 2022
@rolfbjarne
rolfbjarne deleted the dotnet-item-templates branch October 10, 2022 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not-notes-worthy Ignore for release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[net6/7] Templates for "Add File" feature in VSfM

5 participants