Skip to content

[dotnet] Don't try to ILStrip assemblies unless we're connected to a Mac. - #16160

Merged
rolfbjarne merged 1 commit into
dotnet:mainfrom
rolfbjarne:dotnet-ilstrip-skip-unless-connected-to-mac
Sep 28, 2022
Merged

[dotnet] Don't try to ILStrip assemblies unless we're connected to a Mac.#16160
rolfbjarne merged 1 commit into
dotnet:mainfrom
rolfbjarne:dotnet-ilstrip-skip-unless-connected-to-mac

Conversation

@rolfbjarne

@rolfbjarne rolfbjarne commented Sep 27, 2022

Copy link
Copy Markdown
Member

Fixes this error:

targets/Xamarin.Shared.Sdk.targets(754,3): error MSB4018: The "Xamarin.MacDev.Tasks.ILStrip" task failed unexpectedly.
targets/Xamarin.Shared.Sdk.targets(754,3): error MSB4018: System.ArgumentException: 'Assemblies' is required. (Parameter 'Assemblies')
targets/Xamarin.Shared.Sdk.targets(754,3): error MSB4018:    at ILStrip.Execute()
targets/Xamarin.Shared.Sdk.targets(754,3): error MSB4018:    at ILStripTasks.ILStripBase.Execute() in /Users/rolf/work/maccore/main/xamarin-macios/msbuild/Xamarin.iOS.Tasks/Tasks/ILStripBase.cs:line 18
targets/Xamarin.Shared.Sdk.targets(754,3): error MSB4018:    at Xamarin.MacDev.Tasks.ILStrip.Execute() in /Users/rolf/work/maccore/main/xamarin-macios/msbuild/Xamarin.iOS.Tasks/Tasks/ILStrip.cs:line 16
targets/Xamarin.Shared.Sdk.targets(754,3): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
targets/Xamarin.Shared.Sdk.targets(754,3): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask)
 0 Warning(s)
 1 Error(s)

@rolfbjarne
[dotnet] Don't try to ILStrip assemblies unless we're connected to a …
1092ee1 
…Mac.

Fixes this error:

	targets/Xamarin.Shared.Sdk.targets(754,3): error MSB4018: The "Xamarin.MacDev.Tasks.ILStrip" task failed unexpectedly.
	targets/Xamarin.Shared.Sdk.targets(754,3): error MSB4018: System.ArgumentException: 'Assemblies' is required. (Parameter 'Assemblies')
	targets/Xamarin.Shared.Sdk.targets(754,3): error MSB4018:    at ILStrip.Execute()
	targets/Xamarin.Shared.Sdk.targets(754,3): error MSB4018:    at ILStripTasks.ILStripBase.Execute() in /Users/rolf/work/maccore/main/xamarin-macios/msbuild/Xamarin.iOS.Tasks/Tasks/ILStripBase.cs:line 18
	targets/Xamarin.Shared.Sdk.targets(754,3): error MSB4018:    at Xamarin.MacDev.Tasks.ILStrip.Execute() in /Users/rolf/work/maccore/main/xamarin-macios/msbuild/Xamarin.iOS.Tasks/Tasks/ILStrip.cs:line 16
	targets/Xamarin.Shared.Sdk.targets(754,3): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
	targets/Xamarin.Shared.Sdk.targets(754,3): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask)
     0 Warning(s)
     1 Error(s)
@rolfbjarne rolfbjarne added the not-notes-worthy Ignore for release notes label Sep 27, 2022
@rolfbjarne

rolfbjarne commented Sep 27, 2022

Copy link
Copy Markdown
Member Author

/sudo backport release/7.0.1xx-rc2

@rolfbjarne

rolfbjarne commented Sep 27, 2022

Copy link
Copy Markdown
Member Author

/sudo backport release/7.0.1xx-xcode14-rc2

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Sep 27, 2022

Copy link
Copy Markdown
Collaborator

Backport Job to branch release/7.0.1xx-rc2 Created! The magic is happening here

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Sep 27, 2022

Copy link
Copy Markdown
Collaborator

Backport Job to branch release/7.0.1xx-xcode14-rc2 Created! The magic is happening here

Merged
@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Sep 27, 2022

Copy link
Copy Markdown
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6745756 for more details.

Merged
@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Sep 27, 2022

Copy link
Copy Markdown
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6745757 for more details.

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Sep 27, 2022

Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 1092ee142f0f0cc90f6a5f737b464951f160ef93 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Sep 27, 2022

Copy link
Copy Markdown
Collaborator

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

✅ All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: 1092ee142f0f0cc90f6a5f737b464951f160ef93 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Sep 27, 2022

Copy link
Copy Markdown
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: 1092ee142f0f0cc90f6a5f737b464951f160ef93 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Sep 27, 2022

Copy link
Copy Markdown
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1105.Monterey'
Hash: 1092ee142f0f0cc90f6a5f737b464951f160ef93 [PR build]

dalexsoto pushed a commit that referenced this pull request Sep 27, 2022
@vs-mobiletools-engineering-service2 @rolfbjarne
[release/7.0.1xx-xcode14-rc2] [dotnet] Don't try to ILStrip assemblie…
14fc993 
…s unless we're connected to a Mac. (#16162)

Fixes this error:

targets/Xamarin.Shared.Sdk.targets(754,3): error MSB4018: The
"Xamarin.MacDev.Tasks.ILStrip" task failed unexpectedly.
targets/Xamarin.Shared.Sdk.targets(754,3): error MSB4018:
System.ArgumentException: 'Assemblies' is required. (Parameter
'Assemblies')
targets/Xamarin.Shared.Sdk.targets(754,3): error MSB4018: at
ILStrip.Execute()
targets/Xamarin.Shared.Sdk.targets(754,3): error MSB4018: at
ILStripTasks.ILStripBase.Execute() in
/Users/rolf/work/maccore/main/xamarin-macios/msbuild/Xamarin.iOS.Tasks/Tasks/ILStripBase.cs:line
18
targets/Xamarin.Shared.Sdk.targets(754,3): error MSB4018: at
Xamarin.MacDev.Tasks.ILStrip.Execute() in
/Users/rolf/work/maccore/main/xamarin-macios/msbuild/Xamarin.iOS.Tasks/Tasks/ILStrip.cs:line
16
targets/Xamarin.Shared.Sdk.targets(754,3): error MSB4018: at
Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
targets/Xamarin.Shared.Sdk.targets(754,3): error MSB4018: at
Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost
taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost
taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask)
     0 Warning(s)
     1 Error(s)


Backport of #16160

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Sep 27, 2022

Copy link
Copy Markdown
Collaborator

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 223 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

@rolfbjarne
rolfbjarne merged commit 0057862 into dotnet:main Sep 28, 2022
@rolfbjarne
rolfbjarne deleted the dotnet-ilstrip-skip-unless-connected-to-mac branch September 28, 2022 05:29
dalexsoto pushed a commit that referenced this pull request Sep 28, 2022
@vs-mobiletools-engineering-service2 @rolfbjarne
[release/7.0.1xx-rc2] [dotnet] Don't try to ILStrip assemblies unless…
79193a6 
… we're connected to a Mac. (#16161)

Fixes this error:

targets/Xamarin.Shared.Sdk.targets(754,3): error MSB4018: The
"Xamarin.MacDev.Tasks.ILStrip" task failed unexpectedly.
targets/Xamarin.Shared.Sdk.targets(754,3): error MSB4018:
System.ArgumentException: 'Assemblies' is required. (Parameter
'Assemblies')
targets/Xamarin.Shared.Sdk.targets(754,3): error MSB4018: at
ILStrip.Execute()
targets/Xamarin.Shared.Sdk.targets(754,3): error MSB4018: at
ILStripTasks.ILStripBase.Execute() in
/Users/rolf/work/maccore/main/xamarin-macios/msbuild/Xamarin.iOS.Tasks/Tasks/ILStripBase.cs:line
18
targets/Xamarin.Shared.Sdk.targets(754,3): error MSB4018: at
Xamarin.MacDev.Tasks.ILStrip.Execute() in
/Users/rolf/work/maccore/main/xamarin-macios/msbuild/Xamarin.iOS.Tasks/Tasks/ILStrip.cs:line
16
targets/Xamarin.Shared.Sdk.targets(754,3): error MSB4018: at
Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
targets/Xamarin.Shared.Sdk.targets(754,3): error MSB4018: at
Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost
taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost
taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask)
     0 Warning(s)
     1 Error(s)


Backport of #16160

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

Assignees

No one assigned

Labels

not-notes-worthy Ignore for release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto