[UIKit] Add nullability to file - #15857
Conversation
mandel-macaque
left a comment
There was a problem hiding this comment.
Approving as long as the changes requested by @rolfbjarne are done.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Didn't catch a build issue, will commit working version once fixed |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ðŧ [PR Build] Tests on macOS Mac Catalina (10.15) passed ðŧâ All tests on macOS Mac Catalina (10.15) passed. Pipeline on Agent |
ðŧ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed ðŧâ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
â API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
â API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)â Generator diffGenerator diff is empty Pipeline on Agent |
ðĨ [CI Build] Test results ðĨTest resultsâ Tests failed on VSTS: simulator tests 0 tests crashed, 4 tests failed, 219 tests passed. Failuresâ linker testsDetails
Html Report (VSDrops) Download â monotouch testsDetails
Html Report (VSDrops) Download â msbuild testsDetails
Html Report (VSDrops) Download Successesâ
bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
|
Tests failures:
None are related with the change. |
|
/sudo backport xcode14 |
|
Backport Job to branch xcode14 Created! The magic is happening here |
|
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6658871 for more details. |
File did not have nullability enabled. Add nullability and made some changes to code as safeguards.