Skip to content

[workloads] Fix iOS.Windows.Sdk.Aliased.net6 pack name - #15820

Merged
rolfbjarne merged 1 commit into
mainfrom
winsdkalias6
Aug 31, 2022
Merged

[workloads] Fix iOS.Windows.Sdk.Aliased.net6 pack name#15820
rolfbjarne merged 1 commit into
mainfrom
winsdkalias6

Conversation

@pjcollins

@pjcollins pjcollins commented Aug 31, 2022

Copy link
Copy Markdown
Member

Commit 246aa83 missed a manifest pack entry when renaming packs to
include a .net6 suffix, producing an invalid manifest and causing MSI
conversion to fail. Fix this by making sure to use the .net6 suffix
everywhere.

Failing build context: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6627063&view=logs&j=b4ea4e02-2fcb-5a4a-1d1d-96cc58456a90&t=1ef5c69d-aeda-5369-a23d-e57771ac0882&l=119

Commit 246aa83 missed a manifest pack entry when renaming packs to
include a `.net6` suffix, producing an invalid manifest and causing MSI
conversion to fail.  Fix this by making sure to use  the `.net6` suffix
everywhere.
@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

ðŸ’ŧ [PR Build] Tests on macOS Mac Catalina (10.15) passed ðŸ’ŧ

✅ All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: 457a29defdfdef5b9e1b5592f887dee826621573 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 457a29defdfdef5b9e1b5592f887dee826621573 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1042.Monterey'
Hash: 457a29defdfdef5b9e1b5592f887dee826621573 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • introspection

Pipeline on Agent
Hash: 457a29defdfdef5b9e1b5592f887dee826621573 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

ðŸ”Ĩ [CI Build] Test results ðŸ”Ĩ

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 1 tests failed, 222 tests passed.

Failures

❌ monotouch tests

1 tests failed, 22 tests passed.
Details
  • monotouch-test/watchOS 32-bits - simulator/Debug: TimedOut

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

@rolfbjarne

Copy link
Copy Markdown
Member

Test failure is unrelated (https://github.com/xamarin/maccore/issues/2558).

@rolfbjarne
rolfbjarne merged commit ed9aae4 into main Aug 31, 2022
@rolfbjarne
rolfbjarne deleted the winsdkalias6 branch August 31, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants