🔴 Hot News: dotnet/macios/pull/

janwiebe-jump · 2022-08-05T13:12:49Z

As discussed in #9996 the CPListSection constructors are not fully correct, since the CPListImageRowItem can't be added to it, which is possible in the native iOS SDK.
This PR fixes that. With that, also #15622 seems to be fixed.

…f CPListSection

mandel-macaque · 2022-08-05T13:19:39Z

/azp run

azure-pipelines · 2022-08-05T13:20:18Z

Azure Pipelines successfully started running 1 pipeline(s).

mandel-macaque

I believe we need to Obsolete and leave the old ones while providing a path for users to upgrade rather that break the API. Nevertheless I have triggered the build to confirm the API will be broken.

mandel-macaque · 2022-08-05T13:28:55Z

@janwiebe-jump Thanks for the fix! I have some small concerts which I left in the review.

Added Items[] as well, to conform to iOS SDK https://developer.apple.com/documentation/carplay/cplistsection

janwiebe-jump · 2022-08-05T13:43:39Z

Thanks @mandel-macaque , good catch indeed.
I re-added the old constructors, and added the Obsolete attribute.
Next to that, I also added the Items[] property (besides the existing) to conform to the iOS api.

mandel-macaque

We still need to wrap the old api with a #if so that next time we have the chance to break APIs we do not expose something wrong :)

Co-authored-by: Manuel de la Pena <mandel@microsoft.com>

mandel-macaque

Lets see what the tests got to see. But the changes look good to me.

mandel-macaque · 2022-08-05T15:34:21Z

/azp run

janwiebe-jump · 2022-08-05T15:34:55Z

Hmm, the Items property

Lets see what the tests got to see. But the changes look good to me.

Thanks. I am curious how the duplicate Items[] works out

azure-pipelines · 2022-08-05T15:35:06Z

Azure Pipelines successfully started running 1 pipeline(s).

mandel-macaque · 2022-08-05T15:43:11Z

@janwiebe-jump I suspect is going to fail, but it an easy fix (ugly, but doable). I'll keep an eye as according tot he failures I might propose a code change.

Co-authored-by: Manuel de la Pena <mandel@microsoft.com>

Co-authored-by: Alex Soto <alex@alexsoto.me>

mandel-macaque · 2022-08-05T20:33:31Z

/azp run

dalexsoto · 2022-08-15T12:32:25Z

/azp run

azure-pipelines · 2022-08-15T12:33:03Z

Azure Pipelines successfully started running 1 pipeline(s).

dalexsoto · 2022-08-15T12:53:44Z

Looks like our CI is having a hard time :(

rolfbjarne · 2022-08-18T11:49:59Z

/azp run

azure-pipelines · 2022-08-18T11:50:36Z

Azure Pipelines successfully started running 1 pipeline(s).

rolfbjarne · 2022-08-18T12:27:42Z

It doesn't compile:

build/dotnet/ios/generated-sources/CarPlay/CPListSection.g.cs(387,42): error CS8115: A throw expression is not allowed in this context.
build/dotnet/ios/generated-sources/CarPlay/CPListSection.g.cs(387,48): error CS0039: Cannot convert type 'System.InvalidOperationException' to 'Foundation.NSArray' via a reference conversion, boxing conversion, unboxing conversion, wrapping conversion, or null type conversion
make[1]: *** [build/dotnet/ios/32/Microsoft.iOS.dll] Error 1

dalexsoto · 2022-08-20T17:10:38Z

/azp run

azure-pipelines · 2022-08-20T17:11:21Z

Azure Pipelines successfully started running 1 pipeline(s).

vs-mobiletools-engineering-service2 · 2022-08-20T18:21:32Z

🔥 Failed to compare API and create generator diff 🔥

Error: 'make' failed for the hash 1f12270.

Pipeline on Agent
Hash: 1fcaeca530e72a118d9e4292b849dd9aedc199bf [PR build]

vs-mobiletools-engineering-service2 · 2022-08-20T18:50:30Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1109.Monterey'
Hash: 1fcaeca530e72a118d9e4292b849dd9aedc199bf [PR build]

vs-mobiletools-engineering-service2 · 2022-08-20T18:55:33Z

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

✅ All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: 1fcaeca530e72a118d9e4292b849dd9aedc199bf [PR build]

vs-mobiletools-engineering-service2 · 2022-08-20T19:26:23Z

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

introspection
xammac_tests
monotouch-test

Pipeline on Agent
Hash: 1fcaeca530e72a118d9e4292b849dd9aedc199bf [PR build]

vs-mobiletools-engineering-service2 · 2022-08-20T22:02:54Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 223 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

rolfbjarne · 2022-08-22T12:04:46Z

Thanks a lot for your help!

janwiebe-jump · 2022-09-05T07:15:29Z

Hi @rolfbjarne,
Thanks a lot, also for your ant the team's assistance!
Will this also be released as a xamarin-ios version that I can use in my Xamarin iOS (Forms) app? We can't yet move to MAUI / .NET 6, due to a lot of dependencies, so I would strongly prefer a xamarin-ios.pkg version with this fix included, so we can release our CarPlay app.
Thanks so much!

rolfbjarne · 2022-09-05T10:13:52Z

@janwiebe-jump yes, this will be released in a xamarin-ios.pkg (when we release support for Xcode 14, the packages will contain your fix)

Fix dotnet#9996 by using ICPListTemplateItem[] in every constructor o…

024d688

…f CPListSection

janwiebe-jump requested a review from dalexsoto as a code owner August 5, 2022 13:12

mandel-macaque suggested changes Aug 5, 2022

View reviewed changes

Comment thread src/carplay.cs

Comment thread src/carplay.cs

mandel-macaque added the community Community contribution ❤ label Aug 5, 2022

Try to provide upgrade path.

5760a34

Added Items[] as well, to conform to iOS SDK https://developer.apple.com/documentation/carplay/cplistsection

janwiebe-jump requested a review from mandel-macaque August 5, 2022 13:43

mandel-macaque suggested changes Aug 5, 2022

View reviewed changes

Comment thread src/carplay.cs Outdated

Comment thread src/carplay.cs Outdated

Comment thread src/carplay.cs Outdated

janwiebe-jump and others added 4 commits August 5, 2022 17:29

Wrap old api in #if XAMCORE_5_0

8ef1194

Co-authored-by: Manuel de la Pena <mandel@microsoft.com>

Wrap old api in #if XAMCORE_5_0

8a91318

Co-authored-by: Manuel de la Pena <mandel@microsoft.com>

Wrap old api in #if XAMCORE_5_0

644347e

Co-authored-by: Manuel de la Pena <mandel@microsoft.com>

Merge branch 'main' into fix-9996

6717861

mandel-macaque approved these changes Aug 5, 2022

View reviewed changes

This comment has been minimized.

Sign in to view

mandel-macaque suggested changes Aug 5, 2022

View reviewed changes

Comment thread src/carplay.cs

Apply proposed fix vor CPListSection.Items[]

71c1aa9

Co-authored-by: Manuel de la Pena <mandel@microsoft.com>

dalexsoto requested changes Aug 5, 2022

View reviewed changes

Comment thread src/carplay.cs Outdated

Comment thread src/carplay.cs Outdated

Comment thread src/carplay.cs Outdated

janwiebe-jump and others added 3 commits August 5, 2022 20:24

Update src/carplay.cs

535f2ac

Co-authored-by: Alex Soto <alex@alexsoto.me>

Update src/carplay.cs

1231f05

Co-authored-by: Alex Soto <alex@alexsoto.me>

Update src/carplay.cs

93f9fb8

Co-authored-by: Alex Soto <alex@alexsoto.me>

This comment has been minimized.

Sign in to view

Merge branch 'main' into fix-9996

d7adeb5

rolfbjarne approved these changes Aug 18, 2022

View reviewed changes

This comment has been minimized.

Sign in to view

dalexsoto added 2 commits August 19, 2022 19:02

Merge branch 'main' into fix-9996

1f12270

[CarPlay] Fix build

1fcaeca

rolfbjarne merged commit e515b5c into dotnet:main Aug 22, 2022

rolfbjarne mentioned this pull request Aug 22, 2022

Invalid cast of CPListItem to CPListImageRowItem #15622

Closed

janwiebe-jump deleted the fix-9996 branch September 5, 2022 07:13

Uh oh!

Conversation

janwiebe-jump commented Aug 5, 2022

Uh oh!

mandel-macaque commented Aug 5, 2022

Uh oh!

azure-pipelines Bot commented Aug 5, 2022

Uh oh!

mandel-macaque left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mandel-macaque commented Aug 5, 2022

Uh oh!

janwiebe-jump commented Aug 5, 2022

Uh oh!

mandel-macaque left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mandel-macaque left a comment

Choose a reason for hiding this comment

Uh oh!

mandel-macaque commented Aug 5, 2022

Uh oh!

janwiebe-jump commented Aug 5, 2022

Uh oh!

azure-pipelines Bot commented Aug 5, 2022

Uh oh!

mandel-macaque commented Aug 5, 2022

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mandel-macaque commented Aug 5, 2022

Uh oh!

This comment has been minimized.

dalexsoto commented Aug 15, 2022

Uh oh!

azure-pipelines Bot commented Aug 15, 2022

Uh oh!

dalexsoto commented Aug 15, 2022

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne commented Aug 18, 2022

Uh oh!

azure-pipelines Bot commented Aug 18, 2022

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne commented Aug 18, 2022

Uh oh!

dalexsoto commented Aug 20, 2022

Uh oh!

azure-pipelines Bot commented Aug 20, 2022

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 20, 2022

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 20, 2022

📚 [PR Build] Artifacts 📚

Packages generated

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 20, 2022

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 20, 2022

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 20, 2022

🚀 [CI Build] Test results 🚀