[UIKit] Remove the preprocessor directives for watchOS. - #15601
Conversation
This change should have 0/null/nine/nada changes in the API. The goal is to remove the preprocessor directives to ensure that the xcode14 bindings have a smaller diff and are easier to review.
tj-devel709
left a comment
tj-devel709
left a comment
There was a problem hiding this comment.
Pointed out some parts I just wanted to double check
| UIPrinterCutterBehavior ChooseCutterBehavior (UIPrintInteractionController printInteractionController, NSNumber [] availableBehaviors); | ||
| } | ||
|
|
||
| [NoTV] |
There was a problem hiding this comment.
The diff is tricking you :) It was not removed, the delegate was added and then NoWatch was added to the attr. It is in the line 17516 now
| } | ||
|
|
||
| [Deprecated (PlatformName.iOS, 10, 0, message: "Use 'UserNotifications.UNNotificationAction' instead.")] | ||
| [NoWatch] |
There was a problem hiding this comment.
Because it was a partial class in another part of the same file. I merged them to be in a single place.
| [Field ("UIUserNotificationTextInputActionButtonTitleKey")] | ||
| NSString TextInputActionButtonTitleKey { get; } | ||
|
|
||
| #if !WATCH |
There was a problem hiding this comment.
yes, if you look at it, I moved the selector from a partial interface to here. The issue is that I wanted to keep the original version yet keep the interface declaration in a single place.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dalexsoto
left a comment
dalexsoto
left a comment
There was a problem hiding this comment.
Looks good to me, I have some mixed feelings about withespace/aligment but it is a good opportunity to fix them here so ð
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
chamons
left a comment
chamons
left a comment
There was a problem hiding this comment.
LGTM, though the CI should detect if this has an API change.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
âĶ/xamarin-macios into remove-preprocessor-uikit
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ðĨ [PR Build] Build failed ðĨBuild failed for the job 'Detect API changes' Pipeline on Agent |
|
ðĨ Unable to find the contents for the comment: D:\a\1\s\change-detection\results\gh-comment.md does not exist :fire Pipeline on Agent |
ðŧ [PR Build] Tests on macOS Mac Catalina (10.15) passed ðŧâ All tests on macOS Mac Catalina (10.15) passed. Pipeline on Agent |
â [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed âFailed tests are:
Pipeline on Agent |
ðĨ [CI Build] Test results ðĨTest resultsâ Tests failed on VSTS: simulator tests ð All 211 tests passed ð Failuresâ mononative testsðĨ Failed catastrophically on VSTS: simulator tests - mononative (no summary found). Html Report (VSDrops) Download Successesâ
bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
|
/sudo backport xcode14 |
|
Backport Job to branch xcode14 Created! The magic is happening here |
|
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6526007 for more details. |
5 participants
This change should have 0/null/nine/nada changes in the API. The goal is
to remove the preprocessor directives to ensure that the xcode14
bindings have a smaller diff and are easier to review.