[mediaplayer] Add nullability to (generated and manual) bindings - #15147
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| @@ -0,0 +1,46 @@ | |||
| ïŧŋ | |||
There was a problem hiding this comment.
This file is unrelated to this PR and should be removed.
There was a problem hiding this comment.
Whoops, thanks for catching!
mandel-macaque
left a comment
There was a problem hiding this comment.
Do remove the sln.
ðŧ [PR Build] Tests on macOS Mac Catalina (10.15) passed ðŧâ All tests on macOS Mac Catalina (10.15) passed. Pipeline on Agent |
ðŧ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed ðŧâ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
ð [PR Build] API Diff ðAPI diff (for current PR)âđïļ API Diff (from PR only) (please review changes) .NETXamarin vs .NETAPI diff (vs stable)â API Diff from stable .NETXamarin vs .NETGenerator diffâ Generator Diff (no change) Pipeline on Agent XAMBOT-1167.Monterey |
chamons
left a comment
There was a problem hiding this comment.
âĪïļ the test.
I wonder if the test will randomly fail on CI in the future, since the strangest things sometimes do, and something in MediaPlayer feels like it could, but let's add it and remove if it acts up.
|
Unrelated Test Failures: https://github.com/xamarin/maccore/issues/2558 |
This PR aims to bring nullability changes to MediaPlayer.
Following the steps here:
!missing-null-allowed!in this frameworks ignore files and applying them== nullor!= nulltois nullandis not null