Skip to content

[mediaplayer] Add nullability to (generated and manual) bindings - #15147

Merged
tj-devel709 merged 5 commits into
dotnet:mainfrom
tj-devel709:Nullable-MediaPlayer
Jun 6, 2022
Merged

[mediaplayer] Add nullability to (generated and manual) bindings#15147
tj-devel709 merged 5 commits into
dotnet:mainfrom
tj-devel709:Nullable-MediaPlayer

Conversation

@tj-devel709

Copy link
Copy Markdown
Member

This PR aims to bring nullability changes to MediaPlayer.
Following the steps here:

  1. I am looking for any !missing-null-allowed! in this frameworks ignore files and applying them
  2. Changing any == null or != null to is null and is not null

@tj-devel709 tj-devel709 added the not-notes-worthy Ignore for release notes label May 27, 2022
@tj-devel709 tj-devel709 added this to the Future milestone May 27, 2022
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

Comment thread tests/monotouch-test/monotouch-test.sln Outdated
@@ -0,0 +1,46 @@
ïŧŋ

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is unrelated to this PR and should be removed.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, thanks for catching!

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rolfbjarne Addressed!

@mandel-macaque mandel-macaque left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do remove the sln.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1036.Monterey
Hash: 25cb4816d2701a798adcfddabd2c5c666d33fb75

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

ðŸ’ŧ [PR Build] Tests on macOS Mac Catalina (10.15) passed ðŸ’ŧ

✅ All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: 25cb4816d2701a798adcfddabd2c5c666d33fb75

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

ðŸ’ŧ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed ðŸ’ŧ

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: 25cb4816d2701a798adcfddabd2c5c666d33fb75

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

📋 [PR Build] API Diff 📋

API diff (for current PR)

â„đïļ API Diff (from PR only) (please review changes)

API diff: vsdrops gist

Xamarin
.NET
Xamarin vs .NET
iOS vs Mac Catalyst (.NET)

API diff (vs stable)

✅ API Diff from stable

API diff: vsdrops gist

Xamarin
.NET
Xamarin vs .NET
iOS vs Mac Catalyst (.NET)

Generator diff

✅ Generator Diff (no change)

Pipeline on Agent XAMBOT-1167.Monterey
Hash: 25cb4816d2701a798adcfddabd2c5c666d33fb75

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

❌ [CI Build] Tests failed on VSTS: simulator tests iOS ❌

Tests failed on VSTS: simulator tests iOS.

Test results

1 tests failed, 147 tests passed.

Failed tests

  • introspection/watchOS 32-bits - simulator/Debug: Crashed

Pipeline on Agent XAMBOT-1106.Monterey'
Merge 25cb481 into 0307004

@chamons chamons left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

âĪïļ the test.

I wonder if the test will randomly fail on CI in the future, since the strangest things sometimes do, and something in MediaPlayer feels like it could, but let's add it and remove if it acts up.

@tj-devel709

Copy link
Copy Markdown
Member Author

Unrelated Test Failures: https://github.com/xamarin/maccore/issues/2558

@tj-devel709
tj-devel709 merged commit 7731894 into dotnet:main Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not-notes-worthy Ignore for release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants