[msbuild] Fixes Hot Restart compiled Entitlements output path - #15125
Merged
Conversation
The compiled entitlements should be placed in the intermediate Hot Restart app bundle so those can be picked up by the HotRestart Codesign task. Prior to this change, entitlements set in the project wouldn't be included in the app, making things like Keychain Access fail, even though it was configured. Fixes https://developercommunity.visualstudio.com/t/Unable-to-use-MSAL-with-locally-connecte/1573064
mauroa
approved these changes
May 25, 2022
rolfbjarne
approved these changes
May 25, 2022
tj-devel709
approved these changes
May 25, 2022
Collaborator
ðĨ Tests failed catastrophically on VSTS: simulator tests iOS (no summary found). ðĨResult file D:\a\1\s\Reports\TestSummary-simulator\TestSummary.md not found. |
Collaborator
ðŧ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed ðŧâ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
Collaborator
Collaborator
ðŧ [PR Build] Tests on macOS Mac Catalina (10.15) passed ðŧâ All tests on macOS Mac Catalina (10.15) passed. Pipeline on Agent |
dalexsoto
approved these changes
May 26, 2022
Collaborator
â [CI Build] Tests failed on VSTS: simulator tests iOS âTests failed on VSTS: simulator tests iOS. Test results2 tests failed, 146 tests passed.Failed tests
Pipeline on Agent XAMBOT-1108.Monterey' |
Contributor
|
@rolfbjarne @dalexsoto is it okay to merge this? We need it for the next 17.3 preview |
Member
|
Test failures are unrelated:
|
mauroa
pushed a commit
that referenced
this pull request
Jun 1, 2022
The compiled entitlements should be placed in the intermediate Hot Restart app bundle so those can be picked up by the HotRestart Codesign task. Prior to this change, entitlements set in the project wouldn't be included in the app, making things like Keychain Access fail, even though it was configured. Fixes https://developercommunity.visualstudio.com/t/Unable-to-use-MSAL-with-locally-connecte/1573064
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compiled entitlements should be placed in the intermediate Hot Restart app bundle so those can be picked up by the HotRestart Codesign task. Prior to this change, entitlements set in the project wouldn't be included in the app, making things like Keychain Access fail, even though it was configured.
Fixes https://developercommunity.visualstudio.com/t/Unable-to-use-MSAL-with-locally-connecte/1573064